Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CSS: remove unneeded prefixes, add standard properties, remove px from 0s #12648

Merged
merged 1 commit into from
Aug 8, 2016
Merged

CSS: remove unneeded prefixes, add standard properties, remove px from 0s #12648

merged 1 commit into from
Aug 8, 2016

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Aug 4, 2016

  • Add standard transform, filter, animation and width: max-content
  • Remove prefixed border-radius, box-shadow, transition,
    linear-gradient(), box-sizing, text-overflow, flex-direction
    and display: flex
  • Remove prefixed transform from standard @keyframes
  • Remove px from zero values

(Replaces #12163)

…rom 0s

Replaces #12163

* Add standard `transform`, `filter`, `animation` and `width:
max-content`
* Remove prefixed `border-radius`, `box-shadow`, `transition`,
`linear-gradient()`, `box-sizing`, `text-overflow`, `flex-direction`
and `display: flex`
* Remove prefixed `transform` from standard `@keyframes`
* Remove `px` from `0px` values

Fix indentation
@marcelgerber
Copy link
Contributor

Am I right in the assumption that you have had your GitHub name changed? In that case, you need to sign the CLA again (http://dev.brackets.io/brackets-contributor-license-agreement.html).

@valtlai
Copy link
Contributor Author

valtlai commented Aug 4, 2016

@marcelgerber, done.

@valtlai
Copy link
Contributor Author

valtlai commented Aug 5, 2016

What is the Chromium version on Linux now? Maybe prefixed transform, animation and @keyframes can be removed too.

@marcelgerber
Copy link
Contributor

Unfortunately, it's still ~ Chromium 29 on Linux builds.

For some reason, the CLA check still fails, even after re-running the Travis build multiple times. re you sure you have provided the correct username in the form?

@valtlai
Copy link
Contributor Author

valtlai commented Aug 5, 2016

@marcelgerber I think I did.

However, check details contains "x-ratelimit-limit":"60","x-ratelimit-remaining":"0","x-ratelimit-reset":"1470359670"

Edit: and "message":"API rate limit exceeded for 52.22.60.255. too.

@ficristo
Copy link
Collaborator

ficristo commented Aug 7, 2016

Still LGTM, but I prefer if someone else could do the last check.

@marcelgerber
Copy link
Contributor

I would like to have this briefly tested on Linux as well, at least looking out for obvious regressions.
If no one else offers to take over this task, I can probably revive my Linux Mint VM :)

@ficristo
Copy link
Collaborator

ficristo commented Aug 8, 2016

I gave a try on a VM with Ubuntu 16.04 and didn't notice anything obviously wrong.

@marcelgerber
Copy link
Contributor

Going for it in that case. Thank you all!
Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants