Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update Source Code Pro and Source Sans Pro #12663

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marcelgerber
Copy link
Contributor

Updates Source Code Pro to https://github.com/adobe-fonts/source-code-pro/releases/tag/2.030R-ro%2F1.050R-it

Updates Source Sans Pro to https://github.com/adobe-fonts/source-sans-pro/releases/tag/2.020R-ro%2F1.075R-it

In the editor area (that is, Source Code Pro), there is no visual change whatsoever, at least for my sample content (which is normal code using Roman letters).

In the file tree, there are some small visible changes. See #8985 (which is now superseded by this PR) for a long discussion about these changes.

Here's a gif outlining these visible changes:
animate

And here's a diff highlight:
diff

@ficristo
Copy link
Collaborator

Could you try the .otf.woff variants mentioned in the other issue?
I find the new font a little harder to read. (Of course is only my first impression)

/cc @le717 @peterflynn just in case

@marcelgerber
Copy link
Contributor Author

Let's see what @peterflynn thinks about that, as he was probably the biggest opponent of the otf font.
I, too, find the .otf variant is more legible and one can get accustomed to it very quickly.

@le717
Copy link
Contributor

le717 commented Aug 10, 2016

I'm still for switching to the .otf variant for the same reasons as before and as @marcelgerber stated.

@marcelgerber
Copy link
Contributor Author

My earlier comment about Source Code Pro bringing no visible changes was not exactly true - turned out I used another font, which I had forgotten about 🤐

So, here's both a gif and a diff showing the whole window.
Changes were made to both types of quotation marks ' and ", as well as to the triangle Code Folding uses.
Notice that this is a more or less arbitrary example, so there may very well be other changes that are not visible in this code sample.

animation
diff

@ficristo
Copy link
Collaborator

Thinking more, after looking other issues, I think this require a good amount of tests.
Look at this for example: #11249
We should test non romanian characters too: russian, japanese, arabic, etc...

@swmitra
Copy link
Collaborator

swmitra commented Feb 15, 2017

Sorry, missed this PR completely. I am routing this request to people who can actually test the rendering using different character sets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants