Brackets should recognize Linux as a platform #1983
Conversation
Absolutely neccessary for Live Development to function, as an extra /(forward- slash) is added when brackets.platform="win"
ghost
assigned 
|
Reviewing |
|
Thanks @pritambaral. It doesn't look like you've signed our CLA. Here's the link http://dev.brackets.io/brackets-contributor-license-agreement.html and more info here https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets. Please comment here once you you've submitted the CLA. |
| @@ -69,7 +69,12 @@ define(function (require, exports, module) { | |||
|
|
|||
| global.brackets.inBrowser = !global.brackets.hasOwnProperty("fs"); | |||
|
|
|||
| global.brackets.platform = (global.navigator.platform === "MacIntel" || global.navigator.platform === "MacPPC") ? "mac" : "win"; | |||
| if (global.navigator.platform === "MacIntel" || global.navigator.platform === "MacPPC") | |||
There was a problem hiding this comment.
Please add curly braces to each block. Also use 4 spaces for indentation.
|
SIgned. Do include the typo commit too. My bad. :) |
|
All done. |
| @@ -69,7 +69,18 @@ define(function (require, exports, module) { | |||
|
|
|||
| global.brackets.inBrowser = !global.brackets.hasOwnProperty("fs"); | |||
|
|
|||
| global.brackets.platform = (global.navigator.platform === "MacIntel" || global.navigator.platform === "MacPPC") ? "mac" : "win"; | |||
| if (global.navigator.platform === "MacIntel" || global.navigator.platform === "MacPPC") | |||
| { | |||
There was a problem hiding this comment.
Sorry. I should have been more clear. Our open curly braces go on the prior line, not on a new line. Thanks.
|
Done with 2nd pass. |
|
👍 |
|
Sorry for all this mess. I should have read the wiki and guidelines first. |
| global.brackets.platform = (global.navigator.platform === "MacIntel" || global.navigator.platform === "MacPPC") ? "mac" : "win"; | ||
| if (global.navigator.platform === "MacIntel" || global.navigator.platform === "MacPPC") { | ||
| global.brackets.platform = "mac"; | ||
| } |
There was a problem hiding this comment.
Sorry, I missed this. I should have synced and ran JSLint. else if should be on the same line as the close brace.
|
Sorry to miss those other JSLint errors. I should have seen those last time. |
Brackets should recognize Linux as a platform
|
Merged. |
Absolutely neccessary for Live Development to function, as an extra /(forward-
slash) is added when brackets.platform="win"