-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix for #2068: better QuickOpen heuristics #2462
Commits on Jan 1, 2013
-
Configuration menu - View commit details
-
Copy full SHA for ba87bcc - Browse repository at this point
Copy the full SHA ba87bccView commit details -
added longestCommonSubstring to quickopen file.
this is just a checkpoint. my current plan is to remove that function because it slows things down too much
Configuration menu - View commit details
-
Copy full SHA for 4f66e1b - Browse repository at this point
Copy the full SHA 4f66e1bView commit details
Commits on Jan 2, 2013
-
fix 2068: rework quickopen logic to produce better results
Created a new QuickOpen matching algorithm that searches for matches among "special characters" (path markers, camelCase changes) and does so left-to-right rather than right-to-left as in the old algorithm. The new algorithm does still give an added bonus to matches that occur within the filename, which is checked first. Also, there is now a collection of tests to try out the QuickOpen logic and ensure that it is working sanely. The scores look pretty sane now. In this commit, I added some code to help debug scores and was able to get the scores to be pretty sane and the results look quite nice. I also removed the dead code. fix a display bug when there is no query added comments for new QuickOpen algorithm. Note that in the process I spotted a bug and added a failing test, which I have not had a chance to fix yet. partial fix for a bug in the new quickopen logic fixed the bug with strings that are longer than the final segment fix an off-by-one problem that left an initial character match out of the last segment
Configuration menu - View commit details
-
Copy full SHA for e654d09 - Browse repository at this point
Copy the full SHA e654d09View commit details
Commits on Jan 8, 2013
-
first round of cleanup based on pflynn's review feedback. checkpointing
here because I'm going to work on some changes that I might want to roll back (merging lastMatchedIndex and lastRangeCharacter)
Configuration menu - View commit details
-
Copy full SHA for 751e425 - Browse repository at this point
Copy the full SHA 751e425View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c8a5fa - Browse repository at this point
Copy the full SHA 7c8a5faView commit details
Commits on Jan 9, 2013
-
a bunch of changes per pflynn's code review, including some
variable/function renames for clarity. Note that there is currently a failing test. I wanted to put scoring changes into a separate commit, and that should fix the failing test.
Configuration menu - View commit details
-
Copy full SHA for cc9c3ad - Browse repository at this point
Copy the full SHA cc9c3adView commit details -
adds a penalty for matches that don't start on a special character,
which fixes the failing test for samples/index
Configuration menu - View commit details
-
Copy full SHA for 763e785 - Browse repository at this point
Copy the full SHA 763e785View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eafccf - Browse repository at this point
Copy the full SHA 4eafccfView commit details
Commits on Jan 10, 2013
-
review comment responses and the addition of two failing tests that
illustrate bugs found during review
Configuration menu - View commit details
-
Copy full SHA for 57d2628 - Browse repository at this point
Copy the full SHA 57d2628View commit details
Commits on Jan 14, 2013
-
adds backtracking to fix cases where matches that should be found are…
… not. also improves scoring in a number of cases.
Configuration menu - View commit details
-
Copy full SHA for 705b097 - Browse repository at this point
Copy the full SHA 705b097View commit details
Commits on Jan 16, 2013
-
mostly doc changes per review feedback.
There were also a couple of minor code changes (variable renames and such) but no algorithmic changes.
Configuration menu - View commit details
-
Copy full SHA for 112b206 - Browse repository at this point
Copy the full SHA 112b206View commit details
Commits on Jan 17, 2013
-
Configuration menu - View commit details
-
Copy full SHA for bfb4fdf - Browse repository at this point
Copy the full SHA bfb4fdfView commit details -
Merge branch 'master' into dangoor/fix-2068
Conflicts: src/search/QuickOpen.js
Configuration menu - View commit details
-
Copy full SHA for 1bd19a5 - Browse repository at this point
Copy the full SHA 1bd19a5View commit details -
fix _computerangesa not matching _computeRangesAndScore.
The problem was that backtrackTo was causing backtracking to go too far back for the "s", because it had already backtracked to the "r" previously (when it hit the "g" in the query). backtrackTo was the original mechanism I used in backtracking before adding deadBranches. It turns out that backtracking really needs to go back before deadBranches[queryCounter], because where we need to backtrack to depends on where we are in the query.
Configuration menu - View commit details
-
Copy full SHA for 366df47 - Browse repository at this point
Copy the full SHA 366df47View commit details -
scoring tweak to improve results in certain cases (tests added).
@peterflynn noted that "jsutil" matched "JSLintUtils.js" over "JSUtils.js". This change gives a significant boost to consecutive matches that started on a special character. I also boosted specials a little more to balance out specials vs. consecutive matches.
Configuration menu - View commit details
-
Copy full SHA for f325030 - Browse repository at this point
Copy the full SHA f325030View commit details