Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix for #2068: better QuickOpen heuristics #2462

Merged
merged 15 commits into from
Jan 18, 2013
Merged

Commits on Jan 1, 2013

  1. Configuration menu
    Copy the full SHA
    ba87bcc View commit details
    Browse the repository at this point in the history
  2. added longestCommonSubstring to quickopen file.

    this is just a checkpoint. my current plan is to remove that
    function because it slows things down too much
    dangoor committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    4f66e1b View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2013

  1. fix 2068: rework quickopen logic to produce better results

    Created a new QuickOpen matching algorithm that searches for matches
    among "special characters" (path markers, camelCase changes) and
    does so left-to-right rather than right-to-left as in the old algorithm.
    The new algorithm does still give an added bonus to matches that occur
    within the filename, which is checked first.
    
    Also, there is now a collection of tests to try out the QuickOpen logic
    and ensure that it is working sanely.
    
    The scores look pretty sane now.
    
    In this commit, I added some code to help debug scores and was
    able to get the scores to be pretty sane and the results look quite
    nice.
    
    I also removed the dead code.
    
    fix a display bug when there is no query
    
    added comments for new QuickOpen algorithm.
    
    Note that in the process I spotted a bug and added a failing test,
    which I have not had a chance to fix yet.
    
    partial fix for a bug in the new quickopen logic
    
    fixed the bug with strings that are longer than the final segment
    
    fix an off-by-one problem that left an initial character match out of
    the last segment
    dangoor committed Jan 2, 2013
    Configuration menu
    Copy the full SHA
    e654d09 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2013

  1. first round of cleanup based on pflynn's review feedback. checkpointing

    here because I'm going to work on some changes that I might want to
    roll back (merging lastMatchedIndex and lastRangeCharacter)
    dangoor committed Jan 8, 2013
    Configuration menu
    Copy the full SHA
    751e425 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c8a5fa View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2013

  1. a bunch of changes per pflynn's code review, including some

    variable/function renames for clarity.
    
    Note that there is currently a failing test. I wanted to put scoring
    changes into a separate commit, and that should fix the failing test.
    dangoor committed Jan 9, 2013
    Configuration menu
    Copy the full SHA
    cc9c3ad View commit details
    Browse the repository at this point in the history
  2. adds a penalty for matches that don't start on a special character,

    which fixes the failing test for samples/index
    dangoor committed Jan 9, 2013
    Configuration menu
    Copy the full SHA
    763e785 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4eafccf View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2013

  1. review comment responses and the addition of two failing tests that

    illustrate bugs found during review
    dangoor committed Jan 10, 2013
    Configuration menu
    Copy the full SHA
    57d2628 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2013

  1. adds backtracking to fix cases where matches that should be found are…

    … not.
    
    also improves scoring in a number of cases.
    dangoor committed Jan 14, 2013
    Configuration menu
    Copy the full SHA
    705b097 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2013

  1. mostly doc changes per review feedback.

    There were also a couple of minor code changes (variable renames and such)
    but no algorithmic changes.
    dangoor committed Jan 16, 2013
    Configuration menu
    Copy the full SHA
    112b206 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2013

  1. Configuration menu
    Copy the full SHA
    bfb4fdf View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into dangoor/fix-2068

    Conflicts:
    	src/search/QuickOpen.js
    dangoor committed Jan 17, 2013
    Configuration menu
    Copy the full SHA
    1bd19a5 View commit details
    Browse the repository at this point in the history
  3. fix _computerangesa not matching _computeRangesAndScore.

    The problem was that backtrackTo was causing backtracking to go
    too far back for the "s", because it had already backtracked to
    the "r" previously (when it hit the "g" in the query).
    backtrackTo was the original mechanism I used in backtracking
    before adding deadBranches. It turns out that backtracking
    really needs to go back before deadBranches[queryCounter],
    because where we need to backtrack to depends on where we are
    in the query.
    dangoor committed Jan 17, 2013
    Configuration menu
    Copy the full SHA
    366df47 View commit details
    Browse the repository at this point in the history
  4. scoring tweak to improve results in certain cases (tests added).

    @peterflynn noted that "jsutil" matched "JSLintUtils.js" over "JSUtils.js".
    This change gives a significant boost to consecutive matches that started
    on a special character. I also boosted specials a little more to
    balance out specials vs. consecutive matches.
    dangoor committed Jan 17, 2013
    Configuration menu
    Copy the full SHA
    f325030 View commit details
    Browse the repository at this point in the history