This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix issue 2078 #3058
Merged
Fix issue 2078 #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| * @param {string|{{key: string, displayKey: string}}} keyBinding - a single shortcut. | ||
| * @param {?string} platform - undefined indicates all platforms | ||
| * @return {?{key: string, displayKey:String}} Returns a record for valid key bindings. | ||
| * Returns null when key binding platform does not match, binding does not normalize, | ||
| * or is already assigned. | ||
| */ | ||
| function _addBinding(commandID, keyBinding, platform) { | ||
| function _addBinding(command, keyBinding, platform) { |
There was a problem hiding this comment.
_addBinding() is an private function (i.e. it's only called within this file), so it doesn't need to handle both command and commandID.
Only the public API functions (addBinding() and getKeyBindings()) need to be updated.
|
Done with initial review. |
|
Lance, be sure to add a comment to pull requests when you're done with updates so reviewers get an e-mail notification. Looks good. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2078.