This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Validate and install extensions (final) #3157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Doing this separately from the other extension installation changes so we don't overwhelm the diff view on github.)
existence of package.json
missing name and version metadata
…e basic unit tests
… keyboard handling in various states.
…ate, but if you can access the class show() should be public). Also, remove the installer param to _showDialog() since it's never used.
installed (installing into disabled in those cases)
legally, and the test that follows the deleted one catches validation issues in general)
the installation and mocks the extension loading to verify that the extension *would* load. disabled the test because it can only run once and will fail on the second run because there's no way to delete the target directory
(from GitHub for example)
multi-directory-level extension
are installed disabled.
…ng Ok in dialog triggers download, but we don't yet do the validation afterward. No cancelation yet, and errors aren't exposed in UI anywhere. Includes a few cleanups to improve Node connection error cases.
…kage 'backend' layer with state tracked more rigorously. Centralize wrap-up code that runs when a download is over (for whatever reason).
- if you're fast enough to click cancel when it's doing something other than downloading, it won't work right - there's a race condition where sometimes we try to start install/validate before the downloaded file is fully saved to disk - downloaded ZIP file isn't deleted after installation Also fixes a few glitches in the validate/install code and a few formatting issues that fell out of my last rebase.
…ix bug where canceling download switched to error UI state instead of cancelation state.
purpose (per @njx review comment)
readStream, changing to synchronous exists to avoid possible race, handling edge case where there might appear to be a commonPrefix in a zip package but there actually isn't.
…h to disk fully before beginning to process it. * Delete temp downloaded file once it's done being processed. * Small improvements to error result handlng. * Use periods consistently in error message strings & group them with other extension UI strings.
…ll be legit as directory names
just a string, since that is an exceptional condition
…cts, unlike our simple usage of the default Node APIs. Eliminate download-size limit since it seems unimportant & makes the code a bunch more verbose. * Fix bug where we didn't actually clean up downloaded ZIP when done with it.
|
Oops. Forgot to set this to pull into the right branch. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #3137, and should contain just the changes for the installer pull request separate from the node modules in #3156.