This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Make disabledDirectory and apiVersion required for extension installation #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
To @peterflynn |
| @@ -332,10 +332,14 @@ function _removeAndInstall(packagePath, installDirectory, validationResult, call | |||
| * | |||
| * @param {string} Absolute path to the package zip file | |||
| * @param {string} the destination directory | |||
| * @param {{disabledDirectory:string}} additional settings to control the installation | |||
| * @param {{disabledDirectory:string, apiVersion:string}} required additional settings to control the installation | |||
There was a problem hiding this comment.
Could you add the optional nameHint property here too for me? Sorry about the oversight.
There was a problem hiding this comment.
For the required params, we should change the "?"s to "!"s in the JSON docs below too.
|
@dangoor: done reviewing. Just a few nits. |
|
OK, comments addressed (adjusted the comments to reflect required/optional status, made two tests that check that apiVersion and disabledDirectory are both required) |
|
Travis is happy and the comments were nits, so I'm going to go ahead and merge. |
dangoor
added a commit
that referenced
this pull request
Mar 21, 2013
Make disabledDirectory and apiVersion required for extension installation
|
Seems reasonable to me -- thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3159, addressing comments that disabledVersion and apiVersion should be required for the extension installation function.