Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix #3440: Working set does not re-sort when automatic sort is turned on #3450

Merged
merged 1 commit into from
Apr 16, 2013
Merged

Fix #3440: Working set does not re-sort when automatic sort is turned on #3450

merged 1 commit into from
Apr 16, 2013

Conversation

TomMalbran
Copy link
Contributor

This fixes the issue #3440 by sorting the working set after the Automatic Sort is enabled using the current sort method.

@iwehrman
Copy link
Contributor

It looks like the event parameter to Sort._callAutomaticFn isn't used by any of the Sort objects, which is weird. I'm not sure what the use case would even be; maybe to more efficiently resort the list? In any case, that's a question for another day. This fix looks good to me!

iwehrman added a commit that referenced this pull request Apr 16, 2013
Fix #3440: Working set does not re-sort when automatic sort is turned on
@iwehrman iwehrman merged commit 97e2da2 into adobe:master Apr 16, 2013
@TomMalbran TomMalbran deleted the tom/fix-issue-3440 branch April 16, 2013 22:48
@TomMalbran
Copy link
Contributor Author

I actually removed the automaticFn entirely in the request #3080. I needed it for a special MRU sort method, but then that was replaces with Added, so now that function doesn't make much sense. I'll update that pull to call the sort method directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants