This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….findIndex, some, foreach and has, respectively
I'm in favor of replacing @peterflynn - thoughts? |
I've updated the pull request to also completely remove |
ghost
assigned ingorichter
Oct 17, 2013
Conflicts: src/editor/InlineTextEditor.js
Fixed merge conflicts with master. |
Conflicts: src/editor/MultiRangeInlineEditor.js
@iwehrman Looked good! Merged. |
💵 💵 💵 |
https://github.com/adobe/brackets/wiki/Brackets-Coding-Conventions#apis-to-use-or-avoid probably needs an update in light of this change. For example, the part about using CollectionUtils.forEach() or CollectionUtils.some(). |
I made the |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #5229 by adding Lo-Dash as a third-party dependency and deprecating a number of internal functions in favor of their corresponding Lo-Dash functions. In particular, this pull performs the following conversions and deprecations:
Array.slice(0)
to_.clone()
NumberUtils.getRandomNumber()
to_.random
and removesNumberUtils.js
StringUtils.htmlEscape
to._escape
and deprecates the formerCollectionUtils.indexOf
to_.findIndex
and deprecates the formerCollectionUtils.forEach
to_.forEach
and deprecates the formerCollectionUtils.some
to_.some
and deprecates the formerCollectionUtils.hasProperty
to_.has
and deprecates the formerFunctions are deprecated by adding a
@deprecated
annotation, and by replacing their implementation with the corresponding Lo-Dash function and aconsole.warn
message. All the unit tests look good.I'll let @gruehle decide if he wants to replace
Async.whenIdle
with_.debounce
. I also didn't replace instances ofsetTimeout(..., 0)
with_.defer
because the Lo-Dash implementation isn't worth the trouble. (asap does it better.)CC @njx