Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

add 'Korean (ko)' Localization #6272

Merged
merged 5 commits into from
Jan 6, 2014
Merged

add 'Korean (ko)' Localization #6272

merged 5 commits into from
Jan 6, 2014

Conversation

heisice
Copy link
Contributor

@heisice heisice commented Dec 19, 2013

i added Korean Language Localization files. please merge, thanks.

@ghost ghost assigned dangoor Dec 19, 2013
@@ -0,0 +1,507 @@
/*
* Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 2013

@ghost ghost assigned jasonsanjose Dec 19, 2013
@jasonsanjose
Copy link
Member

Thanks @heisice. If you know any other Korean speakers that can review this, please go ahead and tag them here. Also, please sign the contributor license agreement http://dev.brackets.io/brackets-contributor-license-agreement.html so that we can merge this pull request after review.

@heisice
Copy link
Contributor Author

heisice commented Dec 20, 2013

sign contributor license agreement was done. thanks.

@heisice
Copy link
Contributor Author

heisice commented Jan 3, 2014

translation updated. thank you for review, @everyevery.
@jasonsanjose, can you merge this?

@jasonsanjose
Copy link
Member

Thanks @heisice. A few more things to do:

  • Add "LOCALE_KO" : "Korean" to nls/root/strings.js as well as nls/ko/strings.js. Other languages will be updated separately. This is used to display the language name in Debug > Switch Language.
  • Fix indentation to use 4 spaces instead of tabs in nls/ko/strings.js

I can merge this PR as soon as this is done.

replace indentation as four spaces.
add LOCALE_KO
@heisice
Copy link
Contributor Author

heisice commented Jan 4, 2014

ok. all done.
please merge, @jasonsanjose.

"LOCALE_TR": "터키어",
"LOCALE_ZH_CN": "중국어 (간체)",
"LOCALE_HU": "헝가리어",
"LOCALE_KR": "한국어",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the content here, I believe this should have been LOCALE_KO. I'll go ahead and merge this PR and submit a new one with the fix.

jasonsanjose added a commit that referenced this pull request Jan 6, 2014
@jasonsanjose jasonsanjose merged commit 56355ae into adobe:master Jan 6, 2014
@heisice heisice deleted the add-korean-localization branch January 7, 2014 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants