Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Style Extension Update buttons to the match the green notification "badge" #6315

Merged
merged 3 commits into from
Apr 1, 2014

Conversation

stowball
Copy link
Contributor

When an extension has an update, it would be a much better user experience for the Update button to be clearly differentiated in the list (and especially from the Remove button).

Thus, this pull request changes .btn.update to match the green of the notification badge.

@ghost ghost assigned larz0 Jan 2, 2014
// Update Button Type
&.update {
background-color: #91cc41;
border-color: #658e2d;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use #65A015 for border-color.

@larz0
Copy link
Member

larz0 commented Jan 2, 2014

Thanks for this PR @stowball, the usability is much better now.

@larz0
Copy link
Member

larz0 commented Mar 21, 2014

@stowball still up for this?

@stowball
Copy link
Contributor Author

@larz0 Still up for it? What do you mean? I'd love it if you merged it :)

@redmunds
Copy link
Contributor

@stowball

Still up for it? What do you mean? I'd love it if you merged it :)

It looks like @larz0 and others asked you to make some changes first, so look through the comments. Then put a comment in after you push your changes to github so we get an e-mail reminder to do another review. Thanks.

@stowball
Copy link
Contributor Author

@redmunds Ah, sorry. I thought they were changes that you guys wanted to make! I've made them now. Sorry!

@larz0
Copy link
Member

larz0 commented Mar 24, 2014

Great! UX review done. Thanks @stowball!

@larz0 larz0 removed their assignment Mar 24, 2014
box-shadow: inset 0 1px 0 rgba(255, 255, 255, 0.27);
color: #fff;
font-weight: @font-weight-semibold;
text-shadow: 0 -1px 0 rgba(0, 0, 0, 0.24) ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: space before semicolon

@njx
Copy link
Contributor

njx commented Apr 1, 2014

Looks great! I'll just fix the nit after merging.

njx added a commit that referenced this pull request Apr 1, 2014
Style Extension Update buttons to the match the green notification "badge"
@njx njx merged commit e9d6bd9 into adobe:master Apr 1, 2014
@njx njx mentioned this pull request Apr 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants