Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Exclude files from Find in Files operations #7015

Merged
merged 18 commits into from
Mar 6, 2014

Commits on Feb 21, 2014

  1. Configuration menu
    Copy the full SHA
    12456de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56e70d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2014

  1. Configuration menu
    Copy the full SHA
    d960b63 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2014

  1. Configuration menu
    Copy the full SHA
    f87f488 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2014

  1. Configuration menu
    Copy the full SHA
    bafbe88 View commit details
    Browse the repository at this point in the history
  2. First pass at UI for Find in Files exclusion filters. Not wired up to

    seach implementation or prefs yet.
    
    Changes the search bar to use ModalBar's autoClose behavior; no longer
    assumes its code is the only thing to ever close the bar. Adds a new API to
    ModalBar to allow the search bar to be 'locked open' when it would normally
    close, as Find in Files needs for its no-results state and when the filter
    editor dialog is open.
    peterflynn committed Feb 24, 2014
    Configuration menu
    Copy the full SHA
    eb580f1 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/rlim/search-exclusions' into pfl…

    …ynn/search-exclusions
    
    * origin/rlim/search-exclusions:
      Fix JSLint error for extra trailing whitespaces.
      Switch to global view state instead of project-based one and also limit it to ten globs.
      Remove an incorrect assignment.
      Initial implementation search exclusion using project-based view setting.
    peterflynn committed Feb 24, 2014
    Configuration menu
    Copy the full SHA
    ad9cb51 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2014

  1. Wire up file exclusion UI to Find in Files search code & preferences.

    Centralize code in FileFilters module. Switch prefs from single set of at
    most 10 globs to an MRU list of at most 10 separate filters, each of which
    is an unlimited set of globs. Properly update dropdown UI when editing
    dialog is dismissed
    peterflynn committed Feb 25, 2014
    Configuration menu
    Copy the full SHA
    6cec6e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2014

  1. Hoist out a generic DropdownButton widget from CSSInlineEditor, and u…

    …se it
    
    in FileFiters picker UI also, replacing the <select> element it used before.
    
    Further enhance ModalBar to accept focus going to popup elements outside
    its DOM hierarchy if they point back to the ModalBar as the popup's opener.
    peterflynn committed Feb 26, 2014
    Configuration menu
    Copy the full SHA
    0bbaf7a View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2014

  1. File exclusions usability improvements:

    - Automatically add ** prefix and/or suffix in most cases
    - Link to real docs page on wiki
    - Show full filter set in picker button's tooltip
    peterflynn committed Feb 27, 2014
    Configuration menu
    Copy the full SHA
    0068fa7 View commit details
    Browse the repository at this point in the history
  2. Fix bug that snuck into last FileFilters commit at last minute.

    Small starter set of unit tests for FileFilters auto-prefix/suffix behavior.
    
    Also fix whitespace JSLint glitch in unrelated unit-test file.
    peterflynn committed Feb 27, 2014
    Configuration menu
    Copy the full SHA
    7a96840 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2014

  1. Simplify file exclusions UI & prefs after discussion in #7015: single

    filter with no MRU history, and a simple edit button to bring up the
    dialog.
    
    Also ensure focus goes back to search field after dismissing filter-edit
    dialog, per @RaymondLim's suggestion.
    peterflynn committed Feb 28, 2014
    Configuration menu
    Copy the full SHA
    dd94f96 View commit details
    Browse the repository at this point in the history
  2. Basic UI integration tests for Find in Files filtering.

    Fix race condition bug in ProjectManager where getAllFiles() can get stuck
    returning list from previous project, if someone calls it in the middle of
    async project-switching process. Doesn't seem to happen easily in normal
    usage, but unit tests hit this when you call loadProjectInTestWindow(),
    switching from the default project (usually Brackets src) to the test
    projct quickly.
    peterflynn committed Feb 28, 2014
    Configuration menu
    Copy the full SHA
    6a9b292 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2014

  1. Merge remote-tracking branch 'origin/master' into pflynn/search-exclu…

    …sions
    
    * origin/master: (35 commits)
      redraw tree after cancelling node add operation
      Save side bar visibility immediately when not in resizing.
      code review comments. change frameNavigated handling from one to on to handling page navigation within the current project.
      Track performance impact of user viewstate loading
      Updated nls/README.md Step 3 to correspond with the new location of LOCALE_* entries
      Address review comments.
      Better order
      Actually set the USE_TAB_CHAR pref when it needs to be set.
      Set project root path to the project layer immediately after loading the project so that project tree (expanded/collapsed) states can be restored. Explicitly provide project root foler as layer ID so that new project-based keys can be created before recording view states in those keys. Migrate project base url that I missed to convert since it is also one of the old preferences that uses the prefix with the project root path as keys.
      Code review fixes
      sprint 36 - czech language update
      Inject remote functions earlier after frameNavigated instead of loadEventFired
      Add Michael Hernandez to the whitelist.
      Remove .livehtml flag
      Both variable declarations at the same place
      safer check for jquery object
      add comment about why important must be used
      Fix PreferencesManager test.
      Use a variable for the proper string
      Don't start firing preference change events until appReady.
      ...
    
    Conflicts:
    	src/project/ProjectManager.js
    peterflynn committed Mar 1, 2014
    Configuration menu
    Copy the full SHA
    904180a View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2014

  1. Simplify file-exclusion filter syntax so we can use plain regexps ins…

    …tead
    
    of globmatch, for a 100x speedup. With lots of unit tests for the new
    glob-matching engine.
    peterflynn committed Mar 3, 2014
    Configuration menu
    Copy the full SHA
    f8091fe View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2014

  1. Fix bug when clearing filter: move trimming back to editFilter() so we

    reliably detect when filter is blank. (Also fixes potential display bugs
    when there are empty lines within a non-empty filter).
    
    Code review fixes: docs, whitespace nits, strings
    peterflynn committed Mar 5, 2014
    Configuration menu
    Copy the full SHA
    b0ea154 View commit details
    Browse the repository at this point in the history
  2. Merge commit '8572b1d8' into pflynn/search-exclusions

    * commit '8572b1d8':
      Only store the selected entry when there is something selected
      Removes the setInsertHintOnTab method
      Store the selected entry when starting a search and use it when sorting the files
      A better fix suggested from Randy's code review.
      Code review changes
      Rename menuEntry object
      Rename prefs
      Code review changes, change menu entry order
      Strip leading/trailing whitespace from extension url
      Fix nits, use PreferencesManager
      Add unit test for remembering regexp state for Find Next after search bar is closed. Also refactors out some common code from the case sensitivity test.
      Use state of case sensitivity toggle even when find bar isn't open
      Improvements to Close Others
      Changes after first Review
      New Insert Code Hints with Tab Preference
      Handle code completion correctly with auto close braces on.
      Sorts the Find in Files results
    
    Conflicts:
    	src/search/FindInFiles.js
    peterflynn committed Mar 5, 2014
    Configuration menu
    Copy the full SHA
    439ea34 View commit details
    Browse the repository at this point in the history
  3. Code review:

    - move URL into config.json
    - change DropdownButton.itemRenderer to a constructor arg, change default
    renderer to a member function
    - change DropdownButton._renderList() to a member function
    peterflynn committed Mar 5, 2014
    Configuration menu
    Copy the full SHA
    0195c2f View commit details
    Browse the repository at this point in the history