This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixed bug in utils/Async.PromiseQueue where a rejected promise keeps the... #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the PromiseQueue from going to the next promise. Above bug caused by adding to _curPromise.done() instead of _curPromise.always(). Fix is simply to use .always(). Added to Async-test to test rejected promise cases. Signed-off-by: jayther <[email protected]>
|
Looks perfect, thanks! Merging. |
njx
added a commit
that referenced
this pull request
Apr 4, 2014
Fixed bug in utils/Async.PromiseQueue where a rejected promise keeps the...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... PromiseQueue from going to the next promise. ( issue #7393 )
Above bug caused by adding to _curPromise.done() instead of _curPromise.always(). Fix is simply to use .always().
Added to Async-test to test rejected promise cases.
Signed-off-by: jayther [email protected]