Alternative fix for Replace ModalBar with 2 lines #7743
Conversation
| // when there are html menus we need to adjust the top position | ||
| if (!brackets.nativeMenus) { | ||
| var top = $("#titlebar").outerHeight(); | ||
| this._$root.css("top", (top + 10) + "px"); |
There was a problem hiding this comment.
Why is this adjustment only 10px? The adjustment you're replacing uses 37px.
There was a problem hiding this comment.
It should be just top and top is the height of the html menus, which is 37px when it uses 1 line and more when it uses 2. I was doing some testing and forgot to remove the extra 10.
|
I'm seeing some quirks with this branch. I'm using Win7. Also need to test Mac. With HTML menus (and title bar a single line), it transitions down to a small amount (looks like 10px) and then closes the last amount. This happens both for a single line modal bar or a 2 line modal bar. The case with a HTML Menus and 2 line title bar is broken in all 3 branches (master, this branch, and my branch). I tested this branch with only the |
|
@TomMalbran I added a Testing Matrix in description of #7396. |
|
@redmunds I removed the extra 10px that was adding to the top position, which shouldn't be there in the first place. Hopefully that should fix the 10px error with the html menus, since it was placing the modal bars 10px under the menu leaving a gap between the menus and the bar. I did some testing in win8.1 and it works fine for me (with and without html menus, with 1 and 2 lines bars). |
|
Looks good! Merging. |
Alternative fix for Replace ModalBar with 2 lines
@redmunds This is the alternative fix for #7396.
I noticed that using 100% with translate worked fine, so we no longer need to worry about the height of the modal bar. It also fixes an issue when the html menus use 2 lines, or even more.