Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix "Install from URL" issue #9226

Merged
merged 2 commits into from
Sep 30, 2014
Merged

Fix "Install from URL" issue #9226

merged 2 commits into from
Sep 30, 2014

Conversation

marcelgerber
Copy link
Contributor

Fixes #9196. This is a minor behaviour change as well, as clicking in the body won't unfocus the search bar. But I don't think that's a bad thing.

@peterflynn peterflynn added this to the Release 0.44 milestone Sep 26, 2014
@peterflynn
Copy link
Member

@marcelgerber Is the tabIndex stuff even needed? In my testing, everything seems to work fine if you remove all the tabIndex attributes and just leave the one no-focus class.

@marcelgerber
Copy link
Contributor Author

You're right. I now applied the no-focus class to the whole dialog, so that header and footer can't be focused either.

@redmunds redmunds self-assigned this Sep 30, 2014
@redmunds
Copy link
Contributor

Reviewing...

@redmunds
Copy link
Contributor

Looks good. Merging.

redmunds added a commit that referenced this pull request Sep 30, 2014
@redmunds
Merge pull request #9226 from MarcelGerber/extman-install-url
6a91635 
Fix "Install from URL" issue
@redmunds redmunds merged commit 6a91635 into adobe:master Sep 30, 2014
@marcelgerber marcelgerber deleted the extman-install-url branch September 30, 2014 15:50
@peterflynn peterflynn mentioned this pull request Oct 10, 2014
Closed
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@redmunds redmunds

Labels
PR Triage Complete
Projects
None yet
Milestone
Release 0.44
Development

Successfully merging this pull request may close these issues.

"Install from URL" doesn't work any longer
4 participants
@marcelgerber @peterflynn @redmunds @ingorichter