Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Remove even more deprecated code #9640

Merged
merged 5 commits into from
Oct 23, 2014
Merged

Remove even more deprecated code #9640

merged 5 commits into from
Oct 23, 2014

Conversation

le717
Copy link
Contributor

@le717 le717 commented Oct 22, 2014

Even more for #8751.

I did a through scrub of the code base, looking for any pre-0.41 deprecated. I found what I was looking for.
The following is removed with this PR, listed along side the commit they were deprecated with and the release that deprecation went into effect.

  • command/Commands.js and command/Menus.js: Old export redirects (56ab3e9, Sprint 39)
  • editor/Editor.js: jQuery triggerHandler for "keyEvent" (21bea9d, Sprint 38)
  • search/QuickOpen.js: Backwards compatibility for addQuickOpenPlugin() (1ec5c8f, Sprint 23)
  • search/QuickOpen.js: Old export redirects (7d262804728, Sprint 19!) These were technically never deprecated, but they are also not documented either.

Few notes:

  • I came across this: 672c7e (utils/StringMatch.js), which landed in Sprint 25. I did not remove it for fear of breaking it because I do not know how that code works. Again, never deprecated, but it seems it was planned to be. @dangoor Since you made this commit, can you provide some insight here on what should be done?
  • I have not checked extension compatibility yet, but all except the first item will be tricky to catch, as everything else was removing statements in the function/method, not directly access statements or APIs.

Triangle717 added 5 commits October 22, 2014 15:37
adobe/brackets@/1ec5c8f8c70dc4aed5e98e3254904a2e8a55ae48
57d2628

While these exports were technically never deprecated, they were never
documented either, so it's probably not know they still exist.
@le717 le717 mentioned this pull request Oct 23, 2014
ingorichter added a commit that referenced this pull request Oct 23, 2014
@ingorichter ingorichter merged commit d2d9e50 into adobe:master Oct 23, 2014
@le717 le717 deleted the remove-more-deprecated branch October 23, 2014 18:22
@peterflynn
Copy link
Member

Even after @dangoor's PR #9747, it looks like the removals here will break about 20 different extensions. I think we may want to revert some of these changes for 1.0, since some of the removed items (e.g. "keyEvent") were never actually formally deprecated, so authors had zero warning.
(edit: and actually, "keyEvent" is even still listed in our docs...)

@ingorichter remember when reviewing stuff like this that it's always easy to search across all extensions using Kevin's Extension Grabber utility. The search results come back pretty fast, especially if you exclude 'node_modules' folders from the search...

@dangoor
Copy link
Contributor

dangoor commented Oct 31, 2014

I also strongly recommend The Silver Searcher because it's startlingly fast. Just a few seconds to search through all of the extension code.

@dangoor
Copy link
Contributor

dangoor commented Oct 31, 2014

It looks like it's just the keyEvent change that needs to be brought back. We should do that in a PR against the release branch.

@le717
Copy link
Contributor Author

le717 commented Oct 31, 2014

I goofed again. sigh Sorry guys. facepalm

For notes, I have been using the Extension Grabber (and updating the downloads before making changes) and AstroGrep (it's on SourceForge), but it must be missing stuff. I'll try the Silver Searcher on the other PRs once more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants