Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute identifier for Unwrap block statement #52

Closed
felipeS opened this issue Apr 3, 2018 · 2 comments
Closed

Attribute identifier for Unwrap block statement #52

felipeS opened this issue Apr 3, 2018 · 2 comments
Assignees
@raducotescu
Labels
enhancement
Milestone
1.4

Comments

@felipeS
Copy link

felipeS commented Apr 3, 2018

Why the Unwrap block statement data-sly-unwrap doesn't have an Attribute identifier so the result of the test can be used later on?
@raducotescu
Copy link
Member

I guess we didn't consider it important, since if you have an ifelse construct you'd normally use data-sly-test with an identifier to store your expression's result.

Would this solution overcomplicate your markup?

@raducotescu raducotescu self-assigned this Jun 6, 2018
@raducotescu raducotescu added this to the 1.4 milestone Jun 6, 2018
@raducotescu
Copy link
Member

Gave it a bit more thought and this enhancement should be seen as syntactic sugar 🍯.

raducotescu added a commit that referenced this issue Jun 7, 2018
@raducotescu
Attribute identifier for Unwrap block statement
9ee179a 
* closes #52
@raducotescu raducotescu mentioned this issue Jun 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raducotescu raducotescu

Labels
enhancement
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
2 participants
@raducotescu @felipeS