Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add deprecation notice for trigger API #441

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

iuliag
Copy link
Contributor

@iuliag iuliag commented Aug 13, 2024

The trigger API was mainly used previously for triggering scheduled audits directly from the AWS console.
With the introduction of the https://github.com/adobe/spacecat-jobs-dispatcher that is not needed anymore.

Users can now trigger audits on demand via the Slack commands: @spacecat run audit {site} [auditType (optional)]
Run Audit
Usage: run audit {site} [auditType (optional)]
Run audit for a previously added site. Runs lhs-mobile by default if no audit type parameter is provided.

@ekremney
Copy link
Member

@iuliag why is the trigger API being deprecated? Is there an alternative way to trigger audits on-demand as replacement?

@iuliag
Copy link
Contributor Author

iuliag commented Aug 14, 2024

Yes, see the deprecation notice: Please use the Slack commands to trigger audits on-demand.

Copy link

This PR will trigger a patch release when merged.

@iuliag iuliag merged commit c11c5df into main Aug 14, 2024
4 checks passed
@iuliag iuliag deleted the trigger-api-deprecation branch August 14, 2024 13:19
solaris007 pushed a commit that referenced this pull request Aug 14, 2024
## [1.60.5](v1.60.4...v1.60.5) (2024-08-14)

### Bug Fixes

* add deprecation notice for trigger API ([#441](#441)) ([c11c5df](c11c5df))
@solaris007
Copy link
Member

🎉 This issue has been resolved in version 1.60.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants