-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garage week Project – Integration of Firefall for improvement suggestions #18
Draft
dzehnder
wants to merge
85
commits into
main
Choose a base branch
from
garage-week-firefall
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will trigger a minor release when merged. |
# Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Garageweek Project to Fix Recommendations based on Code-Diffs using Firefall (https://adobe.brightidea.com/D50152)
Demo Script:
Generate a baseline Lighthouse report for the website in its optimal state to establish performance benchmarks.
Introduce a deliberate degradation in the website (e.g., adding a blocking while loop for a couple of seconds) to simulate a performance issue.
Generate a new Lighthouse report for the website post-degradation.
Monitor the designated Slack channel for automated recommendations. The system should identify the degradation and suggest actionable recommendations to mitigate the identified issues.
Current PR status:
It is possible to trigger a LHS report using the API, the audit-worker conducts the actual test and sends the result via SQS to the post-processor. The post processor crafts a request to the Firefall API, which should return insights and recommendations based on the code diff, markdown diff and the calculated scores.
After Firefall returns the insights and recommendations, a Slack message is crafted that visualizes the LHS differences and presents the actionable results from Firefall.
Next steps:
Productize:
During the Garage Week, the whole solution was implemented as a prototype. Before the merge it first needs to be transformed into a production-ready solution. This includes creating a Firefall Client that handles the API request and knows how to obtain the prompt, a module that creates the Slack message and a handler that stitches everything together.Reduce Requests to Firefall API
We can reduce the amount of requests to the Firefall API a lot by identifying cases, where no recommendations are needed. For example when the score improved above a certain threshold (like > 90).Testing:
For the Garage Week, test coverage was decreased to 0. This needs to be increased to 100 again. Every newly addd module needs rigorous testing to ensure reliability.