Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sp-textfiield and sp-search to Spectrum CSS ^3.0.0 #761

Merged
merged 3 commits into from
Aug 5, 2020

Conversation

Westbrook
Copy link
Contributor

Description

Directly (or as close to directly as possible) port the textfield and search patterns to ^3.0.0.

Separately, we should review whether the sp-textfield pattern needs to be updated to some form of a light dom <input/> element in order to appropriately pair with label elements and extend to patterns like the stepper #477.

Related Issue

fixes #513
fixes #543
fixes #750

Motivation and Context

Keeping up with Spectrum CSS, making customization easier.

How Has This Been Tested?

  • continues to pass unit tests
  • visual regressions have been slightly updated

Screenshots (if appropriate):

image
image
image

Types of changes

  • dependency management

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Westbrook Westbrook force-pushed the westbrook/textfield-beta branch 8 times, most recently from 83f354a to 1c0ec10 Compare July 14, 2020 16:28
@andrewhatran andrewhatran self-requested a review July 14, 2020 21:33
@andrewhatran
Copy link
Collaborator

The Spectrum CSS changes lgtm 👍 Ready for approval once the circle ci visual tests are addressed.

The <input/> element light dom refactor makes a lot of sense. Agreed that there's a lot of value in making our components more compatible with <form> and <label> elements.

Out of curiosity, how would we leverage our input components inside of a <form> if we decide against moving our <input/> elements into the light DOM?

@Westbrook
Copy link
Contributor Author

If we can avoid having the <input/> in the light DOM, we would need to leverage one or both of the techniques outlined herein in order to leverage the sp-textfield and associated element in <form>: https://web.dev/more-capable-form-controls/ I've named a possible extension of the formdata interface in honor of the best film in Ashton Kutcher's filmography: https://glitch.com/edit/#!/dude-wheres-my-form

@Westbrook Westbrook force-pushed the westbrook/textfield-beta branch 2 times, most recently from 6c28e90 to abd20f1 Compare August 4, 2020 22:39
@Westbrook
Copy link
Contributor Author

@andrewhatran This should be good and caught up. PTAL.

Copy link
Collaborator

@andrewhatran andrewhatran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work

@Westbrook Westbrook merged commit 931f05d into spectrum-css-3 Aug 5, 2020
@Westbrook Westbrook deleted the westbrook/textfield-beta branch August 5, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants