-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move sp-textfiield
and sp-search
to Spectrum CSS ^3.0.0
#761
Conversation
36ed908
to
ef24fac
Compare
83f354a
to
1c0ec10
Compare
The Spectrum CSS changes lgtm 👍 Ready for approval once the circle ci visual tests are addressed. The Out of curiosity, how would we leverage our input components inside of a |
If we can avoid having the |
ef24fac
to
fe876fc
Compare
1c0ec10
to
bc88a45
Compare
fe876fc
to
84ff0e1
Compare
bc88a45
to
d07beda
Compare
9cd027d
to
9bb4d1e
Compare
02022a1
to
97af991
Compare
9bb4d1e
to
9cd77dd
Compare
97af991
to
698c5e8
Compare
e1153d6
to
1c70136
Compare
698c5e8
to
82d1b15
Compare
1c70136
to
7febd88
Compare
82d1b15
to
646b032
Compare
863aaff
to
843a9aa
Compare
040b25d
to
d2108be
Compare
d1bd638
to
4a05d68
Compare
d2108be
to
71b9bce
Compare
f3e03da
to
c19087b
Compare
6c28e90
to
abd20f1
Compare
abd20f1
to
c26ca5a
Compare
@andrewhatran This should be good and caught up. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice work
Description
Directly (or as close to directly as possible) port the
textfield
andsearch
patterns to^3.0.0
.Separately, we should review whether the
sp-textfield
pattern needs to be updated to some form of a light dom<input/>
element in order to appropriately pair withlabel
elements and extend to patterns like thestepper
#477.Related Issue
fixes #513
fixes #543
fixes #750
Motivation and Context
Keeping up with Spectrum CSS, making customization easier.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: