Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing wavelength attribute in example_scan #298

Closed
adokter opened this issue Feb 7, 2020 · 3 comments
Closed

missing wavelength attribute in example_scan #298

adokter opened this issue Feb 7, 2020 · 3 comments
Assignees
@adokter
Labels
sprint
Milestone
0.6.0

Comments

@adokter
Copy link
Owner

adokter commented Feb 7, 2020

example_scan$attributes$how$wavelength is not defined
@adokter adokter modified the milestones: 0.5.0, 0.6.0 Feb 7, 2020
@adokter
Copy link
Owner Author

adokter commented Feb 7, 2020

Also applies to read_pvolfile, which does not automatically populate wavelength attributes of scan objects, in case wavelength attribute is only defined at the higher polar volume level

@adokter adokter added the sprint label Jun 10, 2021
@adokter adokter self-assigned this Jun 10, 2021
adokter added a commit that referenced this issue Jun 10, 2021
@adokter
fix issue #298
47e428d
@bart1
Copy link
Collaborator

bart1 commented Jun 10, 2021

If you are changing example_scan it might also be worth to ensure the order of parameters is the same in as in example_pvol , see #365

adokter added a commit that referenced this issue Jun 10, 2021
@adokter
Merge pull request #453 from adokter/scan_wavelength_attribute
6b22288 
fix issue #298
@adokter
Copy link
Owner Author

adokter commented Jun 10, 2021

@bart1 the order is fixed as well

@adokter adokter closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adokter adokter

Labels
sprint
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@bart1 @adokter