unit tests for calculate_vp() #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/document |
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 40.43% 41.87% +1.43%
==========================================
Files 54 54
Lines 3007 2992 -15
==========================================
+ Hits 1216 1253 +37
+ Misses 1791 1739 -52
Continue to review full report at Codecov.
|
|
@peterdesmet this one is ready for re-review. Most tests only run locally, because they require a running Docker container |
- Use "must" - Use backticks - Use glue() where appropriate
peterdesmet
reviewed
Jun 10, 2021
There was a problem hiding this comment.
@adokter, I have:
- Clarified the documentation + use Markdown
- Standardized the error messsages
- Added the
skip_if_no_docker()function - Improved readability of tests
- Added test for errors on input arguments
3 questions are remaining:
- range_min: can we allow >=0 rather than current >0
- range_max: can we allow >=0 rather than current >0
- n_layer: default is 20L, should that be 20?
peterdesmet
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warningsto enable/suppress vol2bird warnings (add toNEWS.md)