Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #341 #447

Merged
merged 1 commit into from
Jun 9, 2021
Merged

fix issue #341 #447

merged 1 commit into from
Jun 9, 2021

Conversation

adokter
Copy link
Owner

@adokter adokter commented Jun 8, 2021

adds an informative error message when using bind_into_vpts() on profiles with different altitude layers (#341)

@codecov-commenter
Copy link

Codecov Report

Merging #447 (15192fb) into master (d4a3ca8) will increase coverage by 0.70%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   40.42%   41.12%   +0.70%     
==========================================
  Files          54       54              
  Lines        3008     3015       +7     
==========================================
+ Hits         1216     1240      +24     
+ Misses       1792     1775      -17     
Impacted Files Coverage Δ
R/as.data.frame.R 100.00% <ø> (ø)
R/convert_legacy.R 100.00% <ø> (ø)
R/get_elevation_angles.R 100.00% <ø> (ø)
R/param.R 100.00% <ø> (ø)
R/ppi.R 100.00% <ø> (ø)
R/scan.R 100.00% <ø> (ø)
R/zzz.R 0.00% <ø> (ø)
R/bind_into_vpts.R 75.51% <50.00%> (-2.52%) ⬇️
R/doy_noy.R 100.00% <100.00%> (+100.00%) ⬆️
R/get_param.R 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5225309...15192fb. Read the comment docs.

@adokter adokter merged commit 82bcfea into master Jun 9, 2021
@adokter adokter deleted the bind_into_vpts branch June 9, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants