Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind profiles with different number of altitude layers (#343) #457

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Conversation

bart1
Copy link
Collaborator

@bart1 bart1 commented Jun 10, 2021

This should make it possible to combined profiles with different heights as long as they are aligned. I have not adjusted the maxheight attributes as I interpreted this as the height for which it has been calculated and not interpolated

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #457 (c24abba) into master (5cd4918) will increase coverage by 1.26%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   42.82%   44.08%   +1.26%     
==========================================
  Files          53       53              
  Lines        2921     2944      +23     
==========================================
+ Hits         1251     1298      +47     
+ Misses       1670     1646      -24     
Impacted Files Coverage Δ
R/bind_into_vpts.R 83.73% <92.85%> (+8.22%) ⬆️
R/read_pvolfile.R 75.29% <0.00%> (+0.14%) ⬆️
R/pvolfile.R 90.00% <0.00%> (+23.33%) ⬆️
R/vpfile.R 100.00% <0.00%> (+50.00%) ⬆️
R/vpi.R 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd4918...c24abba. Read the comment docs.

@bart1 bart1 requested a review from adokter June 10, 2021 19:09
@adokter adokter changed the title #343 bind profiles with different number of altitude layers (#343) Jun 10, 2021
@adokter
Copy link
Owner

adokter commented Jun 10, 2021

Hi @bart1, I added updating of the attributes$where$levels, since that is an attribute that is required (maxheight isn't always present, so leaving that for now)

@adokter adokter merged commit 25f71e8 into master Jun 10, 2021
@adokter adokter deleted the #343 branch June 10, 2021 20:37
@bart1
Copy link
Collaborator Author

bart1 commented Jun 10, 2021

Hi @bart1, I added updating of the attributes$where$levels, since that is an attribute that is required (maxheight isn't always present, so leaving that for now)

Thanks sorry missed that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants