Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make aws.s3 suggested (#583) #584

Merged
merged 1 commit into from
May 22, 2023
Merged

make aws.s3 suggested (#583) #584

merged 1 commit into from
May 22, 2023

Conversation

bart1
Copy link
Collaborator

@bart1 bart1 commented May 22, 2023

Resolve #583 wait for lets wait for #579 and then resolve conflicts

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #584 (da1f2bc) into master (57085a3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head da1f2bc differs from pull request most recent head c26aaf5. Consider uploading reports for the commit c26aaf5 to get more accurate results

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   67.89%   67.90%   +0.01%     
==========================================
  Files          58       58              
  Lines        3152     3153       +1     
==========================================
+ Hits         2140     2141       +1     
  Misses       1012     1012              
Impacted Files Coverage Δ
R/download_pvolfiles.R 93.44% <100.00%> (+0.10%) ⬆️

@bart1 bart1 changed the title make aws.s3 suggested (#583) make aws.s3 suggested (#583) May 22, 2023
@bart1 bart1 requested a review from PietrH May 22, 2023 19:11
@bart1
Copy link
Collaborator Author

bart1 commented May 22, 2023

As #579 is prepared for this ( b2d42c3 ). This can now be merged

@bart1 bart1 marked this pull request as ready for review May 22, 2023 19:13
@bart1 bart1 merged commit fce98a1 into master May 22, 2023
@bart1 bart1 deleted the aws_s3_sug branch May 22, 2023 19:52
Copy link
Collaborator

@PietrH PietrH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to make aws.s3 suggested, I'll make some changes to #579 to reduce merge conflicts.

DESCRIPTION Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making aws.s3 suggested
3 participants