Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has many validator should work with simple arrays/objects #116

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

offirgolan
Copy link
Collaborator

No description provided.

@@ -23,6 +23,14 @@ var Validations = buildValidations({
lastName: validator(Validators.presence)
});

var BelongsToValidations = buildValidations({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const ?

@offirgolan
Copy link
Collaborator Author

@stefanpenner this one is ready for review as well.

test("has-many relationship is sync", function(assert) {
this.register('validator:belongs-to', BelongsToValidator);

var friend = setupObject(this, Ember.Object.extend(Validations), {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let

@stefanpenner
Copy link
Collaborator

small nit-picks, but otherwise 👍

offirgolan added a commit that referenced this pull request Feb 12, 2016
Has many validator should work with simple arrays/objects
@offirgolan offirgolan merged commit 8028d6f into master Feb 12, 2016
@offirgolan offirgolan deleted the relational-validations branch February 12, 2016 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants