Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null in extractOptionsDependentKeys #266

Merged
merged 1 commit into from
Jul 26, 2016
Merged

Check for null in extractOptionsDependentKeys #266

merged 1 commit into from
Jul 26, 2016

Conversation

xcambar
Copy link
Contributor

@xcambar xcambar commented Jul 26, 2016

Changes proposed:

  • Adds a check for null in extractOptionsDependentKeys (because typeof null === "object")

@offirgolan
Copy link
Collaborator

👍 good catch. Thank you!

@offirgolan offirgolan merged commit 5cfb151 into adopted-ember-addons:master Jul 26, 2016
@xcambar xcambar deleted the null_dependentKeys branch July 26, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xcambar @offirgolan