add allowBlank option to number validator #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,10 @@ const { | |||
|
|
|||
| export default Base.extend({ | |||
| validate(value, options) { | |||
| if (options.allowBlank && isEmpty(value)) { | |||
There was a problem hiding this comment.
To be consistent with the rest of the validators, can you move this block below the variable declaration
|
Ah I totally forgot about this when I wrote this one. Thanks for the PR :D. Besides my note, can you also add the allowBlank options in the docs (docs/docs/validators/number.md). You can just copy it from one of the other ones. |
|
No problem I'll get that in real quick |
|
Looks good. Thank you 😸 |
offirgolan
added a commit
that referenced
this pull request
Nov 3, 2015
add allowBlank option to number validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.