Reproduction of 3.13.0 infinite loop in #659 #660
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces the infinite loop issue I opened in #659
I've added two types of component:
my-component
- js + template, Infinite loop is triggered from the templateanother-component
- js only. Infinite loop is triggered from theinit
hookyarn ember test --server --filter="Integration | Component | my-component: it renders"
yarn ember test --server --filter="Unit | Component | another-component: it creates correctly"
Also worth noting while there is PR to make ember-cp-validations compatible with 3.13 in #653 I find this issue is still happening in spite of cherry-picking that fix. So I opted to keep this PR smaller by only bumping to ember-source 3.13.0-beta.5
Edit: I've also added a reproduction of this happening in a running app (see #659 (comment)). You can see the effects by running
yarn start
and visiting http:localhost:4200.