Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduction of 3.13.0 infinite loop in #659 #660

Conversation

patocallaghan
Copy link

@patocallaghan patocallaghan commented Sep 17, 2019

This reproduces the infinite loop issue I opened in #659

I've added two types of component:

  1. my-component - js + template, Infinite loop is triggered from the template
  2. another-component - js only. Infinite loop is triggered from the init hook

yarn ember test --server --filter="Integration | Component | my-component: it renders"

yarn ember test --server --filter="Unit | Component | another-component: it creates correctly"

Also worth noting while there is PR to make ember-cp-validations compatible with 3.13 in #653 I find this issue is still happening in spite of cherry-picking that fix. So I opted to keep this PR smaller by only bumping to ember-source 3.13.0-beta.5

Edit: I've also added a reproduction of this happening in a running app (see #659 (comment)). You can see the effects by running yarn start and visiting http:localhost:4200.

@patocallaghan
Copy link
Author

Closing as a fix has being released in https://github.com/emberjs/ember.js/releases/tag/v3.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant