Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue in the keyboard service unit test that left key responders registered #154

Merged
merged 1 commit into from
May 21, 2020
Merged

Fix an issue in the keyboard service unit test that left key responders registered #154

merged 1 commit into from
May 21, 2020

Conversation

lukemelia
Copy link
Collaborator

  • Prior to this fix, any click or key press at the end of a test run would throw an error.

@lukemelia
Fix an issue in the keyboard service unit test that left key responde…
da90db8 
…rs registered.

- Prior to this fix, any click or key press at the end of a test run would throw an error.
MelSumner
MelSumner approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for submitting this PR!

@lukemelia lukemelia merged commit 10b1da4 into adopted-ember-addons:master May 21, 2020
@lukemelia lukemelia deleted the bug/test-cleanup branch May 21, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukemelia @MelSumner