Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt release-it to help with changelog and release management #155

Merged
merged 1 commit into from
May 21, 2020
Merged

Adopt release-it to help with changelog and release management #155

merged 1 commit into from
May 21, 2020

Conversation

lukemelia
Copy link
Collaborator

No description provided.

jelhan
jelhan approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Did you wrote the changelog included in this pull request mostly by manually? It doesn't look like lerna-changelog template in most parts.

@lukemelia
Copy link
Collaborator Author

@jelhan thanks! Yes, I recreated it from Github releases to give us a starting point

@Alonski
Copy link
Member

Alonski commented May 21, 2020

Awesome work!

MelSumner
MelSumner approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for doing this work! 👍

@lukemelia lukemelia merged commit 5dfd51f into adopted-ember-addons:master May 21, 2020
@lukemelia lukemelia deleted the chore/release-it branch May 21, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelhan jelhan jelhan approved these changes

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukemelia @Alonski @MelSumner @jelhan