Allow @ember/test-helpers v3 in peer dependencies #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix #729 |
|
I believe we can drop build for ember 3.x now, And I can add @ember/string dependency to fix ember 5. What do you think? |
francois2metz
force-pushed
the
allow-test-helpersv3
branch
from
2401b37
to
7c2f53a
Compare
SergeAstapov
added
enhancement
and removed
dependencies
|
@francois2metz we should do one thing at a time. v3 support should be dropped separately. I think we should be able to land this change as is |
|
@francois2metz could you please revert changes related to v3 build from this PR? it's unrelated to the changes proposed here, we'll work on fixing CI separately |
francois2metz
force-pushed
the
allow-test-helpersv3
branch
from
6295472
to
7c2f53a
Compare
|
@lukemelia could you be able to publish v8.3.0 with this fix? I'll work on making CI green separately |
|
Released as 8.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ember/test-helpers v3 has been released: https://github.com/emberjs/ember-test-helpers/releases/tag/v3.0.0
The
triggerEventfunction used in ember-keyboard is still here, so relaxing the dependencies to allow the v3 is okay.