Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @embroider/addon-shim to ^1.8.9 #378

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Feb 21, 2022

fix #377

@mkszepp mkszepp changed the title Update @embroider to ^1.0.0 Update @embroider to ^1.0.0 Jun 24, 2024
@mkszepp mkszepp changed the title Update @embroider to ^1.0.0 Update dependency @embroider to ^1.0.0 Jun 24, 2024
@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Jun 24, 2024

I sent this via DM, but for others, here is the plan:

I would do this series of PRs:

  • drop support for node < 18 (This is a breaking change, we won't release right away)
  • add @ember/string to the test app
  • then we land your embroider update PR
    • at this point, we can make sure CI is green and cut a new major
  • then we do a v2 addon conversion
    • can be in a minor, as we already require ember-auto-import@v2

4 prs in total

@mkszepp mkszepp changed the title Update dependency @embroider to ^1.0.0 Allow @embroider/addon-shim: ^1.0.0 as dependency Jun 27, 2024
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use old range || new range?

@mkszepp
Copy link
Contributor Author

mkszepp commented Jun 27, 2024

Why use old range || new range?

not sure, if there is something braking between v0.50 and 1.x... but we can also remove v0.50 if you want

@NullVoxPopuli
Copy link
Collaborator

I don't think anything would break, unless folks are pinning the older versions, which it's their own fault at that point

@mkszepp mkszepp changed the title Allow @embroider/addon-shim: ^1.0.0 as dependency Update dependency @embroider/addon-shim: to ^1.0.0 Jun 27, 2024
@mkszepp mkszepp changed the title Update dependency @embroider/addon-shim: to ^1.0.0 Update dependency @embroider/addon-shim to ^1.0.0 Jun 27, 2024
@mkszepp mkszepp changed the title Update dependency @embroider/addon-shim to ^1.0.0 Update dependency @embroider/addon-shim to ^1.8.9 Jun 27, 2024
@NullVoxPopuli NullVoxPopuli merged commit 87e61f0 into adopted-ember-addons:master Jun 27, 2024
20 checks passed
@mkszepp mkszepp deleted the embroider-update branch June 27, 2024 12:36
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency @embroider/addon-shim to ^1.0.0
2 participants