-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danchadwick wip buff up #334
Danchadwick wip buff up #334
Conversation
… reflect action requirement.
…ing action `action`.
…tyle update. When paper-select calls _super() in didReciveAttrs, it will trigger paper-input's assertion, not its own. Rather than assert before the call to _super, simply combine the messages.
Causes ember-paper to be watched during development of another application.
…l examples now function.
- paper-menu now uses `value` instead of `model`. | ||
- paper-checkbox now uses `value` instead of `checked`. | ||
- paper-switch now uses `value` instead of `checked`. | ||
- paper-select now uses required an `onchange` action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be onChange
, right?
@@ -19,9 +19,9 @@ export default Ember.Component.extend(RippleMixin, ProxyMixin, { | |||
|
|||
hasProxiedComponent: Ember.computed.bool('proxiedComponents.length'), | |||
|
|||
hasSecondaryAction: Ember.computed('secondaryItem', 'action', function() { | |||
hasSecondaryAction: Ember.computed('secondaryItem', 'onClick', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not destructure computed from Ember, just like in paper-input.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xomaczar - Absolutely. The purpose of this PR was to make some API changes. The affected file has not been gone thru and adjusted to conform to the ember-paper style guides (in contributing.md). I only touch paper-item to get rid of all the "action" properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanChadwick makes sense
Update a broad variety of small items, bring other components into harmony with already-updated components. See commit messages for details.