Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-button class bindings #365

Merged
merged 8 commits into from
May 5, 2016
Merged

md-button class bindings #365

merged 8 commits into from
May 5, 2016

Conversation

andybeesee
Copy link

Added fab and mini class name bindings, with tests and examples in dummy app. I appreciate any feedback I am still new to this.

Andrew Hollandmoritz added 5 commits May 4, 2016 05:08
…ts for them and iconButton, raised properties
…s when their respective properties are defined
* master:
  link directly to `ember-route-action` helper (#363)
  Bump version to `1.0.0-alpha.0`.
  dummy app: Make version extremely apparent.
  contributing.md: Document building and deploying dummy app to github.io.
@miguelcobain
Copy link
Collaborator

miguelcobain commented May 5, 2016

Thanks! There is a possible improvement here.
When a button is mini it is necessarily a fab. So, when we specify mini=true the button should implicitly assume that fab=true.

Suggestion: Make the default value of fab a computed property that has the value of mini, like

fab: computed.reads('mini')

Also, add or edit a test that makes sure that mini=true adds both md-fab and md-mini.

@andybeesee
Copy link
Author

Good idea, I have made the updates.

@miguelcobain miguelcobain merged commit c959dcc into adopted-ember-addons:master May 5, 2016
@miguelcobain
Copy link
Collaborator

Thanks again.

eriktrom added a commit to eriktrom/ember-paper that referenced this pull request May 6, 2016
* master:
  Add missing trailing EOL in paper-toolbar-test.js.
  Remove self-closing tags in dummy app sidenav.
  fix self closing tags
  Add missing trailing EOL in paper-toolbar.hbs.
  update toolbars (adopted-ember-addons#367)
  use double quotes
  contributing.md: Add comments to coding style.
  Update changelog.md.
  Fix npm 2.x build failures for angular-material-source dependency (adopted-ember-addons#364)
  Toolbar class bindings (adopted-ember-addons#362)
  md-button class bindings (adopted-ember-addons#365)
  progress-circular dummy app: Restore previous behavior inadvertently commented out.
  progress-circular & -linear dummy app: Start/stop progress when route is activated/deactivated.
  link directly to `ember-route-action` helper (adopted-ember-addons#363)
  Bump version to `1.0.0-alpha.0`.
  dummy app: Make version extremely apparent.
  contributing.md: Document building and deploying dummy app to github.io.
  Checkbox & switch examples layout (adopted-ember-addons#361)

# Conflicts:
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants