-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes paper-form an actual html form #649
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2db77e4
Changes tagName of paper-form to `form`.
tyleryasaka bc973c2
Removes the onClick action from the submit button.
tyleryasaka 144e79b
Tests that form onSubmit action is invoked when the html form is subm…
tyleryasaka 1eb5fab
Updates a paper-form test to not use a `button` element for testing f…
tyleryasaka 84f7da5
Updates documentation for paper-form.
tyleryasaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,11 +14,17 @@ const { Component, computed } = Ember; | |
*/ | ||
export default Component.extend(ParentMixin, { | ||
layout, | ||
tagName: '', | ||
tagName: 'form', | ||
isValid: computed.not('isInvalid'), | ||
isInvalid: computed('[email protected]', function() { | ||
return this.get('childComponents').isAny('isInvalid'); | ||
}), | ||
|
||
submit() { | ||
this.send('onSubmit'); | ||
return false; | ||
}, | ||
|
||
actions: { | ||
onValidityChange() { | ||
if (this.get('lastIsValid') !== this.get('isValid')) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change this to an
<a
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelcobain It needs to be something besides
button
, because html buttons submit forms automatically. When it's a button here, theonSubmit
action is called twice. Once because the action is assigned directly to the button, and once because of the form'ssubmit
handler.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyleryasaka That's what happens by default, but I changed it to
<button type="button"
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok - I didn't realize that could be done. 👍