Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ember #690

Merged
merged 6 commits into from
May 8, 2017
Merged

Upgrade Ember #690

merged 6 commits into from
May 8, 2017

Conversation

bjornharrtell
Copy link
Contributor

Depends on #689.

@bjornharrtell bjornharrtell mentioned this pull request Apr 13, 2017
Closed
@bjornharrtell
Copy link
Contributor Author

Rebased.

@bjornharrtell
Copy link
Contributor Author

Another rebase with additional upgrades.

@bjornharrtell
Copy link
Contributor Author

With the latest round of updates including adaptions with a ember init run, the default package manager is now yarn and the qunit problem that was worked around by using an older version (#694) is no longer needed.

@bjornharrtell
Copy link
Contributor Author

Appears I made a premature conclusion, the qunit issue is still there. The yarn.lock was not upgraded.

@miguelcobain miguelcobain merged commit e2e797c into adopted-ember-addons:master May 8, 2017
@miguelcobain
Copy link
Collaborator

Thanks!

@bjornharrtell bjornharrtell deleted the upgrade-ember branch May 9, 2017 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjornharrtell @miguelcobain