Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-test-selectors, fix deprecation warning #441

Closed
sandstrom opened this issue Oct 15, 2021 · 0 comments · Fixed by #446
Closed

Bump ember-test-selectors, fix deprecation warning #441

sandstrom opened this issue Oct 15, 2021 · 0 comments · Fixed by #446

Comments

@sandstrom
Copy link
Contributor

sandstrom commented Oct 15, 2021

Use of this addon triggers a deprecation warning (via ember-test-selectors).

mainmatter/ember-test-selectors#780

DEPRECATION: Reopening the Ember.Component super class itself is deprecated.

Great if would use v6.0.0 of ember-test-selectors or patch it away and stick to 5.x (see below).

mainmatter/ember-test-selectors#721

  let app = new EmberAddon(defaults, {
    'ember-test-selectors': {
      patchClassicComponent: false
    }
  });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant