Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patchClassicComponent option to avoid deprecation warnings #721

Merged
merged 1 commit into from
May 25, 2021

Conversation

mydea
Copy link
Contributor

@mydea mydea commented May 25, 2021

To opt-in to address #709 until a breaking release is made.

This would allow you to specify:

  let app = new EmberAddon(defaults, {
    'ember-test-selectors': {
      patchClassicComponent: false
    }
  });

To avoid including the patch at all, thus avoid the deprecations if you do not use classic components (or the bindings on classic components, at least).

@Turbo87 Turbo87 changed the title Allow to opt out of classic component patching Add patchClassicComponent option to avoid deprecation warnings May 25, 2021
@Turbo87 Turbo87 merged commit 220626c into mainmatter:master May 25, 2021
bors added a commit to rust-lang/crates.io that referenced this pull request May 28, 2021
ember-test-selectors: Disable obsolete/deprecated `Component.reopen()` call

see mainmatter/ember-test-selectors#721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants