Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a modifier version - Part 2 - more streamlined #345

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

cah-brian-gantzler
Copy link
Contributor

@cah-brian-gantzler cah-brian-gantzler commented Dec 19, 2019

Provides for a more streamlined version of the modifier

<ol {{sortable-group onChange=this.update a11yAnnouncementConfig=this.myA11yConfig}}>
  {{#each model.items as |item|}}
    <li {{sortable-item model=item}}>
      {{item.name}}
      <span class="handle" {{sortable-handle}}>&varr;</span>
    </li>
  {{/each}}
</ol>

This implements the purposed issue #342

@st-h
Copy link
Contributor

st-h commented Jan 27, 2020

@cah-briangantzler Is there anything I can help you with here? Just wanted to add this Addon to my app, but noticed it's either refactoring quite a bit of my markup, or making modifiers available.

@cah-brian-gantzler
Copy link
Contributor Author

As far as Im concerned this is completed. Just waiting on them to approve. The modifier version is only back to 3.8, the component version is back farther. I updated the travis to no longer test the older versions.

The tests are failing on the beta and canary (Both component and modifier), I dont know if thats a blocker to releasing this.

If you were refactoring anyway, and on 3.8+ the modifier is definitely the way to go. Gives you more flexibility. We use ember-yeti-table and wanted to make the rows use this addon. We cant with the component version, but can apply the modifiers to the yeti-table component that represents the tr.

@cah-brian-gantzler
Copy link
Contributor Author

Im not sure whats causing the 'no environment variable set' job to be created thats failing. All the tests pass except beta and canary. The travis is set to allow canary to fail, but not beta

@ygongdev
Copy link
Member

ygongdev commented Jan 29, 2020

The beta and canary tests are also failing on master, so I'm thinking something is going on with 3.17+, but I'm ok as long as 3.15 is fine.

@ygongdev ygongdev added enhancement v2 Relates to 2.x.x labels Jan 29, 2020
@ygongdev ygongdev merged commit 663320c into adopted-ember-addons:master Jan 29, 2020
@chriskrycho
Copy link
Contributor

👏 thanks for driving this, @cah-briangantzler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement v2 Relates to 2.x.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants