-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a modifier version - Part 2 - more streamlined #345
Conversation
2848778
to
af7572e
Compare
f1aa75d
to
15b00c4
Compare
@cah-briangantzler Is there anything I can help you with here? Just wanted to add this Addon to my app, but noticed it's either refactoring quite a bit of my markup, or making modifiers available. |
As far as Im concerned this is completed. Just waiting on them to approve. The modifier version is only back to 3.8, the component version is back farther. I updated the travis to no longer test the older versions. The tests are failing on the beta and canary (Both component and modifier), I dont know if thats a blocker to releasing this. If you were refactoring anyway, and on 3.8+ the modifier is definitely the way to go. Gives you more flexibility. We use ember-yeti-table and wanted to make the rows use this addon. We cant with the component version, but can apply the modifiers to the yeti-table component that represents the tr. |
…s (modifier version)
Im not sure whats causing the 'no environment variable set' job to be created thats failing. All the tests pass except beta and canary. The travis is set to allow canary to fail, but not beta |
The beta and canary tests are also failing on master, so I'm thinking something is going on with |
👏 thanks for driving this, @cah-briangantzler! |
Provides for a more streamlined version of the modifier
This implements the purposed issue #342