-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-option declared without x-select error #44
Comments
Here's the console output for the error:
|
If it helps to know how I'm grouping the data, that looks like this: grouped_by = function(content, key) {
var result = Ember.A();
forEach(content.sortBy(key), function(item) {
var label = item.get(key);
if (result.get('lastObject.label') !== label) {
result.pushObject({
label: label,
content: []
});
}
result.get('lastObject.content').push(item);
});
return result;
} |
Possibly related: emberjs/ember.js#11170 |
i seen this error before but it had to do with promise bindings not being fully settled in time |
Interesting. Are you running the Ember 2.0 beta right now? And what version of Emberx-select? |
Yes. Beta 1. Latest version of emberx-select. 0.12.4 IIRC. |
Correction: 1.1.4 |
Gotcha, can you try master right now? We haven't released a version that's glimmer compat yet since we have to do some semvar stuff. I'm in the middle of a blog post that's details what the plan is. Basically: 1.13 broke us a little bit so we're going to only support 1.13/2.0 in Emberx-select 2.0. In order to do that we need to make sure 1.10-1.12 users have a working 1.x version. (Ember broke Edit: You should be able to use master by doing |
I'll give the master branch a try! |
@tpitale Did that help at all? |
I'm at work right now, haven't gotten to it yet. |
I set: "emberx-select": "git://github.com/thefrontside/emberx-select.git#master" In my package.json, and ran If it did, then master exhibits the same issue with 2.0.0 beta 1. It seems that detecting nearest parent view of the x-select component no longer works through the yield in the component template. I've added comments to other ember/glimmer related issues. |
Here's an example of what other projects have done. https://github.com/IvyApp/ivy-tabs/pull/3/files It seems instead of just I can send a PR with this idea implemented, if you'd like. |
+1 on this. I have the same bug.
|
we're on 1.13.3 |
I'm using master in this repo as well, same issue |
Can you guys update to Ember 1.13.4 and see if that fixes it? |
Ember 1.13.4 broke a lot of stuff for us. I can't upgrade just yet. But I will soon and let you know |
Okay cool. This smells like an ember bug :P |
Still broken in ember 2 beta. Just FYI. |
Hello, I am having the same issue with Ember 1.13.12 and emberx-select 2.0.2. My template looks like this:
where tasks is a computed property. When tasks becomes non-empty, I get the error message mentioned in the first post. It seems like the How could I fix it? |
Hello, I am experiencing the same issue. |
Hi @horacekj can you tell me what versions of Ember/ Emberx-select you're using? |
I use Ember 1.13.15 and emberx-select 2.0.2. My problem is basically the same as yaqwsx's problem: error is raised when the computed property I use #each on changes (in yasqwsx's example it is |
Can you give master a shot? There might be a fix in there. If not we can open a new separate issue. :) |
I have installed xselect from thefrontside/emberx-select#master (
|
Any progress? |
Can you open a new issue? I'll be able to take a look tonight |
Added #99. |
The README mentions that using
<optgroup>
should be possible when usingx-select
block form. I'm having a bit of a hard time getting the block form version to work. I use the blockless version just fine in other cases.Here's what I'm trying to run:
If I add some debugging to the
x-option
component to try to find theparentView
, I'm only getting back aview outlet
. Not sure if this is a change to ember in the 2.0 beta 1, or something else.If I have a chance, I'll try to downgrade back to 1.13 to find out.
Thanks for your help!
Maintainer note: Anyone coming across this issue please try upgrading to Ember 1.13.4. If that doesn't solve your problem, I'd love to hear more :) -@Robdel12
The text was updated successfully, but these errors were encountered: