Switch to yield the select to the block #45
Conversation
tpitale
commented
Jul 11, 2015
tpitale
commented
- accept select on x-option
- use select on x-option when register
- fallback to nearestNeighbor for non-ember-2 beta
- yield select to the block in handlebars
- pass the select for blockless version
* accept select on x-option * use select on x-option when register * fallback to nearestNeighbor for non-ember-2 beta * yield select to the block in handlebars * pass the select for blockless version
|
Attempt to resolve #44. |
| @@ -55,9 +64,9 @@ export default Ember.Component.extend({ | |||
| this._super.apply(this, arguments); | |||
|
|
|||
| Ember.run.scheduleOnce('afterRender', () => { | |||
| var select = this.nearestOfType(XSelectComponent); | |||
| /* Use an assigned select, or search for one nearby */ | |||
| var select = this.get('select') || this.nearestOfType(XSelectComponent); | |||
There was a problem hiding this comment.
Still check for nearestOfType to try to avoid breaking anyone that hasn't upgrade to a version of ember that breaks it anyway.
|
I'm going to go ahead and close this since this bug is actually an ember bug. It should be fixed in 1.13.4. If not we'll revisit :D |
|
This bugfix is gone in ember 2 beta. I believe it was intentionally removed. So, this will probably be broken again shortly. This PR supports both the explicit yield, and the old syntax in 1.13.4. And it appears to be the way ember wants components to move. |
Can you point me to what you mean? |
|
I'm also unsure how well the addon works in the beta right now. We need to upgrade ember-mocha to see where our test suite is at :) |
|
I'll try beta 3. It just appeared that the conversation was saying the code is or would soon be deprecated. I'm mostly concerned because I can't find the bug fix from 1.13.4 in master in |
|
emberjs/ember.js#11170 That conversation. |
|
FWIW, I actually would prefer to not use |
|
From emberjs/ember.js#11170 (comment):
tldr; what @cowboyd said 😺 |
|
@tpitale - The actual code changes to fix the behavior has changed (done a different way now), but all the tests added in emberjs/ember.js#11266 are still included and passing on beta and canary of Ember. |
|
Thanks @rwjblue. I'll try beta 3. |
