Use a specific name for SCC #275
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some tests [1] that fail because the SCC name is too large. The SCC name when the aot test flag is set is derived from the test name. In order to prevent this issue, simply use the same name for all tests. This is ok because prior to and after running tests, all SCCs are destroyed. Additionally, this does not impact any future ability to run tests in parallel as this is already not possible; the fact that all SCCs are destroyed between tests means that test could impact the validity of another. [1] eclipse-openj9/openj9#14461 Signed-off-by: Irwin D'Souza <[email protected]>
|
@smlambert @llxia could you please review? |
|
fyi @pshipton |
llxia
approved these changes
Feb 9, 2022
smlambert
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some tests [1] that fail because the SCC name is too large.
The SCC name when the aot test flag is set is derived from the test
name. In order to prevent this issue, simply use the same name for all
tests. This is ok because prior to and after running tests, all SCCs are
destroyed. Additionally, this does not impact any future ability to run
tests in parallel as this is already not possible; the fact that all
SCCs are destroyed between tests means that one test could impact the
validity of another.
[1] eclipse-openj9/openj9#14461
Fixes eclipse-openj9/openj9#14461