-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment triggered PR builds enhancements #2296
Comments
The |
How should the repo and branch to be provided for building the SDK? |
Both build-jdk and build-openj9 currently auto supports PRs in related repos, i.e. AdoptOpenjdk/openjdk-builds, Eclipse/openj9, Eclispe/openj9-omr, ibmruntimes/openj9-openjdk-jdk${version}. Need to update if we'd like to support explicitly passing in repo/branch info. |
I think if we could predict the archive extension the prediction logic should be in AdoptOpenJDK/install-jdk action. That is the action could be enhanced to enable it. |
So if I'm understanding this correctly, then If so, it seems like this may be better as a separate GitHub workflow rather than tacking it onto this comment triggered PR build workflow. |
If using There are two other scenarios :
For case 1 is common build-jdk | build-openj9 will need to be updated. |
Changes are delivered. I think we can close this issue. |
Recently, we enabled comment-triggered PR builds #2199 (Thanks @Icohedron). There are a couple of enhancements that we would like to add:
--sdk_resource
can be a URL. It is the same asCUSTOMIZED_SDK_URL
in Grinder that users can provide a URL for downloading SDK. We should use this SDK for testing. We can ignore credentials for now.The text was updated successfully, but these errors were encountered: