Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify a specific repo and branch #24

Open
Icohedron opened this issue Mar 9, 2021 · 2 comments
Open

Add option to specify a specific repo and branch #24

Icohedron opened this issue Mar 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Icohedron
Copy link

Currently this action either pulls from the upstream AdoptOpenJDK/openjdk-build repo, or pulls from the head of a PR.
I would like to have the option to specify my own repo and branch to implement comment-triggered PR builds using a custom repo and branch.

@karianna karianna added the enhancement New feature or request label Mar 17, 2021
@Icohedron
Copy link
Author

@sophia-guo any progress on this?

@Icohedron
Copy link
Author

Icohedron commented Apr 9, 2021

I noticed that the getOpenjdkBuildResource does not check out the PR ref at all when usePRRef=true, and instead uses an existing openjdk-build directory in the workspace. This can be seen by the function invocation on line 60 of builder.ts and the implementation of the function on line 108 of builder.ts

I will use this behavior as a workaround for the lack of custom repo and branch options by checking out the custom repo+branch into the openjdk-build directory in the workspace to able using this with issue-comment-triggered GitHub workflows. (i.e. implementing build functionality for adoptium/aqa-tests#2296)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants