Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update git clone logic in build.xml #4846

Open
llxia opened this issue Nov 1, 2023 · 2 comments
Open

Update git clone logic in build.xml #4846

llxia opened this issue Nov 1, 2023 · 2 comments

Comments

@llxia
Copy link
Contributor

llxia commented Nov 1, 2023 •
edited
Loading

We have encountered lots of test material staging problems (see build.xml). In the build.xml, the logic is complicated as we try to handle lots of different cases.

To make this simple, if git cmd fails, we should remove the pre-staged material and re-clone.

related:

  • infrastructure/issues/8508
  • backlog/issues/1255
  • backlog/issues/1248
@llxia
Copy link
Contributor Author

llxia commented Nov 23, 2023

@annaibm can you take a look at this one? Thanks

annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 28, 2023
@annaibm
Update git clone logic in build.xml
fa9b88f 
- Removes prestaged jck material and reclones it, if git command fails

resolves: adoptium#4846
annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 28, 2023
@annaibm
Update git clone logic in build.xml
e9c7eb9 
- Removes prestaged jck material and reclones it, if git command fails

resolves: adoptium#4846

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 28, 2023
@annaibm
Update git clone logic in build.xml
51a8132 
- Removes prestaged jck material and reclones it, if git command fails
resolves: adoptium#4846
Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm mentioned this issue Nov 28, 2023
Closed
@llxia
Copy link
Contributor Author

llxia commented Dec 12, 2023 •
edited
Loading

Here is the general logic:

  • if the material does not exist, git clone it
  • if it exists, check SHA
  • if SHA does not match, update
  • if the update fails, git hard reset
  • if any of the above cmd fails (not due to wrong repo, network issue, etc), remove the test material and git clone again

annaibm added a commit to annaibm/aqa-tests that referenced this issue Dec 13, 2023
@annaibm
Update git cmd logic in build.xml
4c58920 
- Removes prestaged jck material and reclones it, if git command fails

resolves: adoptium#4846

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 9, 2024
@annaibm
Update git cmd logic in build.xml
3aca90e 
- Removes prestaged jck material and reclones it, if git command fails

resolves: adoptium#4846

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 19, 2024
@annaibm
Update git cmd logic in build.xml
2ed66f1 
- Removes prestaged jck material and reclones it, if git command fails

resolves: adoptium#4846

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 19, 2024
@annaibm
Update git cmd logic in build.xml
7f8381c 
- Removes prestaged jck material and reclones it, if git command fails

resolves: adoptium#4846

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 19, 2024
@annaibm
Update git cmd logic in build.xml
d19fefc 
- Removes prestaged jck material and reclones it, if git command fails

resolves: adoptium#4846

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Jan 22, 2024
@annaibm
Update git cmd logic in build.xml
08081d5 
- Removes prestaged jck material and reclones it, if git command fails

resolves: adoptium#4846

Signed-off-by: Anna Babu Palathingal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Adoptium Backlog
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update git clone logic in build.xml annaibm/aqa-tests
1 participant
@llxia