Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISC-V support to OpenJDK test suites #1832

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Add RISC-V support to OpenJDK test suites #1832

merged 1 commit into from
Jun 19, 2020

Conversation

ChengJin01
Copy link

Signed-off-by: Cheng Jin [email protected]

@ChengJin01
Copy link
Author

ChengJin01 commented Jun 15, 2020

Note: the value of SPEC uses riscv-64 instead of riscv64.
If we agree to change to riscv64, then https://github.com/AdoptOpenJDK/TKG/blob/master/src/org/openj9/envInfo/JavaInfo.java needs to be updated to support this.

public String getSPEC() {
 ...
        String model = System.getProperty("sun.arch.data.model");
        System.out.println("System.getProperty('sun.arch.data.model')=" + model + "\n");
        if (Integer.parseInt(model.trim())==64) {
            spec += "-64"; <----- to be updated for riscv64
            spec = spec.replace("arm-64", "aarch64");
        }

Reviewer: @llxia

FYI: @ShelleyLambert , @sxa

@ChengJin01
Copy link
Author

ChengJin01 commented Jun 17, 2020

The SPEC for RISC-V has changed to riscv64 to align with the naming of buildspec in OpenJ9.

@llxia
Copy link
Contributor

llxia commented Jun 17, 2020

Could you test this PR with adoptium/TKG#83 using Grinder_TKG on any platform? Thanks

@ChengJin01
Copy link
Author

Could you test this PR with AdoptOpenJDK/TKG#83 using Grinder_TKG on any platform? Thanks

Launched at Test_grinder/job/Grinder_TKG/632 with the changes at #1832 & adoptium/TKG#83

@llxia
Copy link
Contributor

llxia commented Jun 19, 2020

The above Grinder failed because of missing test image. Relaunched at Grinder_TKG/640

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit d8bc4ea into adoptium:master Jun 19, 2020
@llxia llxia mentioned this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants