Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit for jck_sync job #4715

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Initial commit for jck_sync job #4715

merged 5 commits into from
Sep 28, 2023

Conversation

KapilPowar
Copy link
Contributor

@KapilPowar KapilPowar commented Aug 22, 2023 •
edited
Loading

#1165

Signed-off-by: Kapil Powar [email protected]

CC: @llxia

@KapilPowar KapilPowar changed the title Initial commit for jck_sunc job Initial commit for jck_sync job Aug 22, 2023
@KapilPowar KapilPowar marked this pull request as ready for review August 22, 2023 15:06
@KapilPowar KapilPowar marked this pull request as draft August 22, 2023 15:06
@kapilpowar17
Initial commit for jck_sync job
5868e41 
Initial commit for jck_sync job

create jck_sync job

Add arguments for jck_sync job
@kapilpowar17
Articatory url and JCK git url change
f5d4fbc 
Articatory url  and JCK git url change
@KapilPowar KapilPowar marked this pull request as ready for review September 18, 2023 15:23
llxia
llxia reviewed Sep 20, 2023
View reviewed changes
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
buildenv/jenkins/jck_sync Show resolved Hide resolved
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
llxia
llxia reviewed Sep 20, 2023
View reviewed changes
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
@kapilpowar17
Review changes
aeb9e0b 
Review changes
llxia
llxia reviewed Sep 22, 2023
View reviewed changes
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
llxia
llxia reviewed Sep 27, 2023
View reviewed changes
buildenv/jenkins/jck_sync Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Sep 27, 2023 •
edited
Loading

@KapilPowar could you provide a test job link? Thanks

@kapilpowar17
Review changes
7e0fa28 
Review changes
@KapilPowar
Copy link
Contributor Author

KapilPowar commented Sep 28, 2023 •
edited
Loading

Below are the test job links
Grinder Test -- PR #52 created.
Grinder Test --- No updates.

@llxia
Copy link
Contributor

llxia commented Sep 28, 2023

Thanks @KapilPowar .

  • Could we fix the warning?
    image
  • Please remove the extra unnecessary parameters in the JCK_Sync job

@KapilPowar
Copy link
Contributor Author

Thanks @llxia
Will work on string-interpolation warning in upcoming PR. In enhancement PR will remove unnecessary parameters in JCK_SYNC job.
Thanks

llxia
llxia approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LongyuZhang
LongyuZhang approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 202f05c into adoptium:master Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@LongyuZhang LongyuZhang LongyuZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KapilPowar @llxia @LongyuZhang @kapilpowar17