Do not use dockerAgents on ci.adoptium.net #4931

sxa · 2023-12-21T15:03:29Z

This is a change to prevent the changes from #4307 from taking effect on the adoptium CI. It can still be used elsewhere, but for now the functionality run these agents does not work on our jenkins instances and causes jobs to be queued up indefinitely waiting for an image which will not be created if all of the real machines are in use. The defined image is also using an older version of qemu which would not be suitable for our needs. We will likely look to resovle these issues going forward.

It may be preferable to have an override at the PLATFORM_MAP level earlier in the file where this is defined, and ultimately we want to have this functionality enabled (For RVV support) but for now this is the easiest way to stop the test failing to run.

Ref: adoptium/temurin-build#3591

Signed-off-by: Stewart X Addison <[email protected]>

sxa · 2023-12-21T15:11:00Z

Verified in https://ci.adoptium.net/job/Grinder/8327 which queued successfully when given a specific node label to run on

luhenry · 2023-12-21T15:14:42Z

Do I understand correctly that this is related to "Disable dynamic pool for testing, and queue test jobs for execution on boards"?

sxa · 2023-12-21T15:17:36Z

Do I understand correctly that this is related to "Disable dynamic pool for testing, and queue test jobs for execution on boards"?

Correct. This should resolve that problem.

sxa · 2023-12-22T08:55:58Z

Noting that https://ci.adoptium.net/job/Grinder/8349/console seemed to work ok without this change on on dockerhost-equinix-ubuntu2004-x64-1 but that is not universal across our other machines.

sophia-guo · 2023-12-22T15:29:02Z

buildenv/jenkins/openjdk_tests

-            dockerAgents = PLATFORM_MAP[params.PLATFORM]["DockerAgents"] ? PLATFORM_MAP[params.PLATFORM]["DockerAgents"] : []
+            // Block dockerAgents on adoptium CI for riscv64 until we make it work
+            // This will allow RISC-V test jobs to queue up and not hang
+            if ( env.JENKINS_URL.contains("ci.adoptium.net")) {


This will stop other linux test jobs using dynamic agents. Is this expected?

For RISC-V specifically, maybe limit to if ( env.JENKINS_URL.contains("ci.adoptium.net") && SPEC.equals('linux_riscv64')) ?

I could do, but what other platforms do we do this for? I was under the impression it was only RISC-V and we didn't have the support for it on others

sxa · 2023-12-27T13:13:50Z

For now I've disabled the machines in the set ci.role.test&&sw.os.linux&&sw.tool.docker&&hw.arch.x86 which are not able to perform this function (verified with the smoke test, so fairly basic) which should allow the test jobs to run through successfully

smlambert · 2023-12-27T13:49:56Z

Please do not disable https://ci.adoptium.net/label/ci.role.test&&sw.os.linux&&sw.tool.docker&&hw.arch.x86/ machines,
if you do, then external test jobs will fail. We have recently re-enabled them and in 1Q will be working on fixing them to run green. https://ci.adoptium.net/job/Test_openjdk17_hs_sanity.external_x86-64_linux/

The purpose of external tests:
https://github.com/adoptium/aqa-tests/tree/master/external#roadmap

sxa · 2023-12-27T16:33:30Z

Please do not disable https://ci.adoptium.net/label/ci.role.test&&sw.os.linux&&sw.tool.docker&&hw.arch.x86/ machines, if you do, then external test jobs will fail.

Yep I'm aware of that I've ensured that I'm only changing a subset of them which are being problematic. There should still be enough to run the x64 tests - bear in mind that one of the remaining ones has five executors on it. If you still think that's a problem let me know. This is also an interim measure until this PR can be merged.

luhenry · 2024-01-15T08:40:25Z

@sxa @smlambert @sophia-guo how can we move that forward? It's blocking testing for RISC-V on boards-only, which is impossible today for the weekly runs. Happy to have that disabled for RISC-V explicitly. Thanks!

smlambert · 2024-01-15T13:26:32Z

As a temporary approach, incorporating Sophia's review comments would move this forward.

As the actual approach for this feature, this is not the path I would like us to take.

As per this comment, I would like the images to be an input parameter to the test jobs
#4626 (comment)

smlambert

Approving as a temporary approach.

karianna

Approving since Shelly is OK with it :-)

Signed-off-by: Stewart X Addison <[email protected]>

* Add missing $(TIMEOUT_HANDLER) to serviceability_jvmti_j9 and others (#4961) The $(TIMEOUT_HANDLER) is missing from the serviceability_jvmti_j9 playlist. Add it to a number of playlists where it's missing but may be useful in the future. Signed-off-by: Peter Shipton <[email protected]> * aix: exclude java/lang/String/concat/IntegerMinValue.java (#4968) Signed-off-by: Stewart X Addison <[email protected]> * Exclude specific Windows testcases (#4965) * Exclude specific Windows testcases Signed-off-by: Shelley Lambert <[email protected]> * Add TestCrashAtIGVNSplitIfSubType Signed-off-by: Shelley Lambert <[email protected]> * Exclude JMXStartStopTest on win32 JDK8 Signed-off-by: Shelley Lambert <[email protected]> * Exclude TestRemoveEmptyCountedLoop on win32 Signed-off-by: Shelley Lambert <[email protected]> * Remove the jdk8 changes Signed-off-by: Shelley Lambert <[email protected]> --------- Signed-off-by: Shelley Lambert <[email protected]> * Do not use dockerAgents on ci.adoptium.net (#4931) Signed-off-by: Stewart X Addison <[email protected]> * Exclude known issues on jdk8 (#4971) * Exclude known issues on jdk8 Signed-off-by: Sophia Guo <[email protected]> * Update JMXStartStopTest linked issue Signed-off-by: Sophia Guo <[email protected]> --------- Signed-off-by: Sophia Guo <[email protected]> --------- Signed-off-by: Peter Shipton <[email protected]> Signed-off-by: Stewart X Addison <[email protected]> Signed-off-by: Shelley Lambert <[email protected]> Signed-off-by: Sophia Guo <[email protected]> Co-authored-by: Peter Shipton <[email protected]> Co-authored-by: Stewart X Addison <[email protected]> Co-authored-by: Shelley Lambert <[email protected]>

sxa force-pushed the let_riscv_queue branch from 7f8958c to 1e5d995 Compare December 21, 2023 15:07

Do not use dockerAgents on ci.adoptium.net

daf7ca1

Signed-off-by: Stewart X Addison <[email protected]>

sxa force-pushed the let_riscv_queue branch from 1e5d995 to daf7ca1 Compare December 21, 2023 15:09

sxa requested review from sophia-guo and smlambert December 21, 2023 15:11

sxa self-assigned this Dec 21, 2023

luhenry mentioned this pull request Dec 21, 2023

RISC-V build plan adoptium/temurin-build#3591

Open

7 tasks

luhenry approved these changes Dec 21, 2023

View reviewed changes

sophia-guo reviewed Dec 22, 2023

View reviewed changes

sxa mentioned this pull request Jan 5, 2024

dockerhost-equinix-x64-1 unable to run binfmt for riscv64 testing adoptium/infrastructure#3330

Open

smlambert approved these changes Jan 15, 2024

View reviewed changes

karianna approved these changes Jan 15, 2024

View reviewed changes

sxa merged commit a403063 into adoptium:master Jan 16, 2024
1 check passed

sophia-guo pushed a commit to sophia-guo/openjdk-tests that referenced this pull request Jan 16, 2024

Do not use dockerAgents on ci.adoptium.net (adoptium#4931)

067814d

Signed-off-by: Stewart X Addison <[email protected]>

smlambert mentioned this pull request Jan 29, 2024

Dynamic agent label with hw.arch.x86&&sw.os.linux&&ci.agent.dynamic doesn't work #5013

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not use dockerAgents on ci.adoptium.net #4931

Do not use dockerAgents on ci.adoptium.net #4931

sxa commented Dec 21, 2023 •

edited

Loading

sxa commented Dec 21, 2023

luhenry commented Dec 21, 2023

sxa commented Dec 21, 2023

sxa commented Dec 22, 2023 •

edited

Loading

sophia-guo Dec 22, 2023

sophia-guo Dec 22, 2023

sxa Dec 27, 2023 •

edited

Loading

sxa commented Dec 27, 2023

smlambert commented Dec 27, 2023

sxa commented Dec 27, 2023 •

edited

Loading

luhenry commented Jan 15, 2024 •

edited

Loading

smlambert commented Jan 15, 2024

smlambert left a comment

karianna left a comment

Do not use dockerAgents on ci.adoptium.net #4931

Do not use dockerAgents on ci.adoptium.net #4931

Conversation

sxa commented Dec 21, 2023 • edited Loading

sxa commented Dec 21, 2023

luhenry commented Dec 21, 2023

sxa commented Dec 21, 2023

sxa commented Dec 22, 2023 • edited Loading

sophia-guo Dec 22, 2023

Choose a reason for hiding this comment

sophia-guo Dec 22, 2023

Choose a reason for hiding this comment

sxa Dec 27, 2023 • edited Loading

Choose a reason for hiding this comment

sxa commented Dec 27, 2023

smlambert commented Dec 27, 2023

sxa commented Dec 27, 2023 • edited Loading

luhenry commented Jan 15, 2024 • edited Loading

smlambert commented Jan 15, 2024

smlambert left a comment

Choose a reason for hiding this comment

karianna left a comment

Choose a reason for hiding this comment

sxa commented Dec 21, 2023 •

edited

Loading

sxa commented Dec 22, 2023 •

edited

Loading

sxa Dec 27, 2023 •

edited

Loading

sxa commented Dec 27, 2023 •

edited

Loading

luhenry commented Jan 15, 2024 •

edited

Loading