Adapted to most recent changes in churn - arguments support #5129

judovana · 2024-03-07T15:50:27Z

No description provided.

It canbe easily suplied by churn custom. Afaik it is better to remove it then to disable it

judovana · 2024-03-09T11:40:22Z

Single gc 5h https://ci.adoptium.net/view/Test_grinder/job/Grinder/9064/tapResults/
all gc 60s total: https://ci.adoptium.net/view/Test_grinder/job/Grinder/9065/tapResults/

Will now try all platfroms, but looks ok to me: https://ci.adoptium.net/view/Test_grinder/job/Grinder/9066/

Hmm.. Hard to say if ZGC's failures on cigwin are as expected: [0.014s][error][gc] Failed to lookup symbol: VirtualAlloc2
And on s390x, both zgc and shenandoah reports that they do not exists, even if the -XX+enableThem is present.
Interesting

judovana · 2024-03-10T10:50:50Z

churn_5h_allGCs https://ci.adoptium.net/view/Test_grinder/job/Grinder/9077/
disabled.churn_custom "zgc shenandoah" 60 https://ci.adoptium.net/view/Test_grinder/job/Grinder/9076/
disabled.churn_custom "zgc wrong" 60 https://ci.adoptium.net/view/Test_grinder/job/Grinder/9078/

judovana · 2024-03-11T08:50:05Z

churn_5h_allGCs https://ci.adoptium.net/view/Test_grinder/job/Grinder/9077/
this long one, had not proopagated

rerun with archive artifacts: https://ci.adoptium.net/view/Test_grinder/job/Grinder/9079/

disabled.churn_custom "zgc shenandoah" 60 https://ci.adoptium.net/view/Test_grinder/job/Grinder/9076/

rerun with archive artifacts: https://ci.adoptium.net/view/Test_grinder/job/Grinder/9080/

disabled.churn_custom "zgc wrong" 60 https://ci.adoptium.net/view/Test_grinder/job/Grinder/9078/

Otherwise the jobs did what they should

judovana · 2024-03-11T17:57:48Z

09:50:02  churn_5h_allGCs_0 Start Time: Mon Mar 11 08:50:02 2024 Epoch Time (ms): 1710147002275
09:50:02  variation: NoOptions
09:50:02  JVM_OPTIONS:  
09:50:02  { \
09:50:02  echo "";	echo "TEST SETUP:"; \
09:50:02  echo "Nothing to be done for setup."; \
09:50:02  mkdir -p "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_17101470013550/churn_5h_allGCs_0"; \
09:50:02  cd "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_17101470013550/churn_5h_allGCs_0"; \
09:50:02  echo "";	echo "TESTING:"; \
09:50:02  export JREJDK="jdk" ; \
09:50:02              export OTOOL_garbageCollector="ALL" ; \
09:50:02              export DURATION="18000" ; \
09:50:02              if [ "x" == "x" ] ; then  export CHURN_TAP=false  ; fi ; \
09:50:02              export TMPRESULTS="""/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_17101470013550/churn_5h_allGCs_0"/report""; \
09:50:02              cd MPRESULTS ; \
09:50:02                bash "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../system/churn/churn/run.sh"; \
09:50:02              if [ $? -eq 0 ]; then echo "-----------------------------------"; echo "churn_5h_allGCs_0""_PASSED"; echo "-----------------------------------"; cd /home/jenkins/workspace/Grinder/aqa-tests/TKG/..;  else echo "-----------------------------------"; echo "churn_5h_allGCs_0""_FAILED"; echo "-----------------------------------"; fi; \
09:50:02  echo "";	echo "TEST TEARDOWN:"; \
09:50:02  echo "Nothing to be done for teardown."; \
09:50:02   } 2>&1 | tee -a "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_17101470013550/TestTargetResult";
09:50:02  
09:50:02  TEST SETUP:
09:50:02  Nothing to be done for setup.
09:50:02  
09:50:02  TESTING:
09:50:02  /bin/sh: 10: [: x: unexpected operator
09:50:02  /bin/sh: 12: cd: can't cd to MPRESULTS

it is not healthy

judovana · 2024-03-11T18:00:30Z

What kid of shell is running that?
I guess the fix for MPRESULTS will be ${TMPRESULTS} or $$TMPRESULTS ?

judovana · 2024-03-11T18:03:53Z

https://ci.adoptium.net/view/Test_grinder/job/Grinder/9085/

smlambert · 2024-03-11T19:07:41Z

Same issue you had with setting APPLICATION_OPTIONS, yes, needs $( )

Also, I should take a closer look at how this is run directly, as you should not need cd TMPRESULTS, since TKG sets up the temp location to run and gather results. Also, still seeing the rogue extra and differently formatted .tap file, which is unwanted, as its presence will cause confusion as the Jenkins scripts are expecting the TKG formated tap files, and automatically package them up to include for marketplace API.

judovana · 2024-03-12T06:49:24Z

Same issue you had with setting APPLICATION_OPTIONS, yes, needs $( )

Also, I should take a closer look at how this is run directly, as you should not need cd TMPRESULTS, since TKG sets up

@jandrlik advised thi s to me, that it necessary to have the artifacts properly picked up.

the temp location to run and gather results. Also, still seeing the rogue extra and differently formatted .tap file, which is unwanted, as its presence will cause confusion as the Jenkins scripts are expecting the TKG formated tap files, and automatically package them up to include for marketplace API.

Exactly, the tap file should not be there. It is if-outed, but the

 /bin/sh: 10: [: x: unexpected operator

Is causing it reappear. In the currently pushed pushed version, the rogue tap file is missing. I just wanted to make it more explicit and the escaping had bitten me.

judovana · 2024-03-12T06:55:17Z

churn_5h_allGCs https://ci.adoptium.net/view/Test_grinder/job/Grinder/9091/
disabled.churn_custom https://ci.adoptium.net/view/Test_grinder/job/Grinder/9092/

judovana · 2024-03-12T07:11:34Z

Being out of tmpresults is ok. All artifacts are packed.
The /bin/sh: 10: [: x: unexpected operator is still there. Any idea?

judovana · 2024-03-12T13:07:35Z

churn_5h_allGCs https://ci.adoptium.net/view/Test_grinder/job/Grinder/9094
disabled.churn_custom https://ci.adoptium.net/view/Test_grinder/job/Grinder/9095

judovana · 2024-03-12T13:35:24Z

churn_5h_allGCs https://ci.adoptium.net/view/Test_grinder/job/Grinder/9096
disabled.churn_custom https://ci.adoptium.net/view/Test_grinder/job/Grinder/9097

judovana · 2024-03-12T19:52:54Z

churn_5h_allGCs https://ci.adoptium.net/view/Test_grinder/job/Grinder/9121
disabled.churn_custom https://ci.adoptium.net/view/Test_grinder/job/Grinder/9122

Now it should behave. Dash is no shell of mine :)

karianna

Number of typos

system/churn/README.md

system/churn/playlist.xml

judovana · 2024-03-13T08:44:17Z

churn_5h_allGCs https://ci.adoptium.net/view/Test_grinder/job/Grinder/9121 disabled.churn_custom https://ci.adoptium.net/view/Test_grinder/job/Grinder/9122

Now it should behave. Dash is no shell of mine :)

@smlambert The alien tapfile si finally gone from defautl job! \o/

@karianna ty! will fix asap

Co-authored-by: Martijn Verburg <[email protected]>

judovana · 2024-03-13T08:57:15Z

@karianna thanx again for the additional spell check. I will be more careful next time. All applied.

Co-authored-by: Martijn Verburg <[email protected]>

sophia-guo · 2024-03-13T19:40:21Z

system/churn/playlist.xml

-            export TMPRESULTS="$(Q)$(REPORTDIR)$(D)report$(Q)"; \
-            cd $TMPRESULTS ; \
-              bash "$(TEST_ROOT)$(D)system$(D)churn$(D)churn$(D)run.sh"; \
+            if [ "x${CHURN_TAP}" = "x" ] ; then export CHURN_TAP=true ; fi ; \


What's the CHURN_TAP ?

A tap file that Jiri generates himself, which does not conform to the same information as the tap file that TKG generates, so I asked that it not be generated when running as part of AQAvit, as we use the TKG formated tap files for many purposes and having a non-conformant tap file on the system would be sub-optimal.

See comments in original PR starting here for background.

CHURN_TAP is control variable, which inside churn runner generate tap file - if empty or true. If it is set an non true, then tap file is not generated.

The tap file from churn is extremely useful so I let it on for the custom manual run. However it disturbed the automated tuns, so it is off for default auto run.

If you insists, I will turn it off also for manual run.

The condition is here, so the user from cmdline can control the behaviour.

Worth a comment in the code if this causes confusion

smlambert

👍

…#5129) * Adapted to most recent changes in churn - arguments support * Improved application_options by $() subshell * removed churn_1m_allGCs It canbe easily suplied by churn custom. Afaik it is better to remove it then to disable it * Narrowed readme.md * Using consistently $() instead of $ and ${} * Returned {} instead of () for nkn-jenkins vars * Replaced dash incompatible == by = * removed forgotten _churn_1m_allGCs from readme Co-authored-by: Martijn Verburg <[email protected]> * fixed typos in system/churn/README.md Co-authored-by: Martijn Verburg <[email protected]> * One more remvoal of churn_1m_allGCs and from system/churn/README.md Co-authored-by: Martijn Verburg <[email protected]> * remvoed redundant whitesapces in system/churn/playlist.xml Co-authored-by: Martijn Verburg <[email protected]> * more removed spaces in system/churn/playlist.xml Co-authored-by: Martijn Verburg <[email protected]> --------- Co-authored-by: Martijn Verburg <[email protected]>

Adapted to most recent changes in churn - arguments support

065d114

judovana marked this pull request as draft March 7, 2024 15:50

Improved application_options by $() subshell

91818c9

judovana force-pushed the churn2 branch from 432e38f to 80311f3 Compare March 9, 2024 11:37

removed churn_1m_allGCs

a94184a

It canbe easily suplied by churn custom. Afaik it is better to remove it then to disable it

judovana force-pushed the churn2 branch from 80311f3 to a94184a Compare March 9, 2024 11:38

judovana marked this pull request as ready for review March 9, 2024 11:40

Narrowed readme.md

f5e3459

judovana force-pushed the churn2 branch from 819e2e1 to f5e3459 Compare March 10, 2024 10:52

karianna approved these changes Mar 11, 2024

View reviewed changes

Using consistently $() instead of $ and ${}

0822870

judovana force-pushed the churn2 branch from 34f64e1 to 0822870 Compare March 12, 2024 06:53

Returned {} instead of () for nkn-jenkins vars

342f98d

judovana force-pushed the churn2 branch from 69998fd to 342f98d Compare March 12, 2024 13:34

Replaced dash incompatible == by =

5f74f06

karianna requested changes Mar 13, 2024

View reviewed changes

judovana and others added 4 commits March 13, 2024 09:45

removed forgotten _churn_1m_allGCs from readme

99236a6

Co-authored-by: Martijn Verburg <[email protected]>

fixed typos in system/churn/README.md

b167aec

Co-authored-by: Martijn Verburg <[email protected]>

One more remvoal of churn_1m_allGCs and from system/churn/README.md

eac64da

Co-authored-by: Martijn Verburg <[email protected]>

remvoed redundant whitesapces in system/churn/playlist.xml

be1d489

Co-authored-by: Martijn Verburg <[email protected]>

more removed spaces in system/churn/playlist.xml

2d261c6

Co-authored-by: Martijn Verburg <[email protected]>

sophia-guo reviewed Mar 13, 2024

View reviewed changes

judovana requested a review from karianna March 14, 2024 16:53

karianna approved these changes Mar 15, 2024

View reviewed changes

smlambert approved these changes Mar 15, 2024

View reviewed changes

smlambert merged commit 802a3ed into adoptium:master Mar 15, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapted to most recent changes in churn - arguments support #5129

Adapted to most recent changes in churn - arguments support #5129

judovana commented Mar 7, 2024

judovana commented Mar 9, 2024 •

edited

Loading

judovana commented Mar 10, 2024

judovana commented Mar 11, 2024

judovana commented Mar 11, 2024

judovana commented Mar 11, 2024

judovana commented Mar 11, 2024

smlambert commented Mar 11, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

karianna left a comment

judovana commented Mar 13, 2024

judovana commented Mar 13, 2024

sophia-guo Mar 13, 2024

smlambert Mar 13, 2024

judovana Mar 14, 2024

karianna Mar 15, 2024

smlambert left a comment

Adapted to most recent changes in churn - arguments support #5129

Adapted to most recent changes in churn - arguments support #5129

Conversation

judovana commented Mar 7, 2024

judovana commented Mar 9, 2024 • edited Loading

judovana commented Mar 10, 2024

judovana commented Mar 11, 2024

judovana commented Mar 11, 2024

judovana commented Mar 11, 2024

judovana commented Mar 11, 2024

smlambert commented Mar 11, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

judovana commented Mar 12, 2024

karianna left a comment

Choose a reason for hiding this comment

judovana commented Mar 13, 2024

judovana commented Mar 13, 2024

sophia-guo Mar 13, 2024

Choose a reason for hiding this comment

smlambert Mar 13, 2024

Choose a reason for hiding this comment

judovana Mar 14, 2024

Choose a reason for hiding this comment

karianna Mar 15, 2024

Choose a reason for hiding this comment

smlambert left a comment

Choose a reason for hiding this comment

judovana commented Mar 9, 2024 •

edited

Loading